linux-ppp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* ppp-2.4.4b1 released
@ 2005-08-29  3:10 Paul Mackerras
  2005-08-29  4:19 ` James Cameron
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Paul Mackerras @ 2005-08-29  3:10 UTC (permalink / raw)
  To: linux-ppp

I have just put ppp-2.4.4b1.tar.gz on the samba.org ftp server at:

ftp://ftp.samba.org/pub/ppp/ppp-2.4.4b1.tar.gz

This is mostly a bug-fix release, with many bugs fixed to do with
persist mode and demand dialling.  The one new feature is that pppd
now runs an /etc/ppp/ip-pre-up script after creating the ppp interface
and putting the negotiated IP addresses on it but before marking it
up.  Since pppd waits for this script to finish, it must run quickly.

Please test.  If there are no problems with it, I will re-release it
as ppp-2.4.4 final.

Paul.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: ppp-2.4.4b1 released
  2005-08-29  3:10 ppp-2.4.4b1 released Paul Mackerras
@ 2005-08-29  4:19 ` James Cameron
  2005-09-13 10:24 ` Pasi Kärkkäinen
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: James Cameron @ 2005-08-29  4:19 UTC (permalink / raw)
  To: linux-ppp

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Successful test.  Seemed snappier during initial negotiation, but didn't
try to find out why.  Test configuration was two i686 lab boxes running
Linux 2.6.12.5 with Matt Domsch's current MPPE patch, connection via
pptp 1.5.0 and pptpd 1.3.0.

My test /etc/ppp/ip-pre-up script was executed.

-- 
James Cameron                         http://quozl.netrek.org/
HP Open Source, Volunteer             http://opensource.hp.com/
PPTP Client Project, Release Engineer http://pptpclient.sourceforge.net/

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: ppp-2.4.4b1 released
  2005-08-29  3:10 ppp-2.4.4b1 released Paul Mackerras
  2005-08-29  4:19 ` James Cameron
@ 2005-09-13 10:24 ` Pasi Kärkkäinen
  2005-09-19 12:27 ` Pasi Kärkkäinen
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Pasi Kärkkäinen @ 2005-09-13 10:24 UTC (permalink / raw)
  To: linux-ppp

On Mon, Aug 29, 2005 at 01:10:20PM +1000, Paul Mackerras wrote:
> I have just put ppp-2.4.4b1.tar.gz on the samba.org ftp server at:
> 
> ftp://ftp.samba.org/pub/ppp/ppp-2.4.4b1.tar.gz
> 
> This is mostly a bug-fix release, with many bugs fixed to do with
> persist mode and demand dialling.  The one new feature is that pppd
> now runs an /etc/ppp/ip-pre-up script after creating the ppp interface
> and putting the negotiated IP addresses on it but before marking it
> up.  Since pppd waits for this script to finish, it must run quickly.
> 
> Please test.  If there are no problems with it, I will re-release it
> as ppp-2.4.4 final.
>

Hi!

Could you please add this patch to pppd?

http://nrg.joroinen.fi/ppp/pppd-2.4.3-radius-dns-wins-1.diff

It adds support for fetching dns- and wins-server information from radius..
If radius server does not reply with dns/wins information, the values from
the pppd configuration file are used.

Or if there's something in this patch you'd like to be changed, please tell me.

Thanks!

-- Pasi Kärkkäinen
 
       
                                   ^
                                .     .
                                 Linux
                              /    -    \
                             Choice.of.the
                           .Next.Generation.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: ppp-2.4.4b1 released
  2005-08-29  3:10 ppp-2.4.4b1 released Paul Mackerras
  2005-08-29  4:19 ` James Cameron
  2005-09-13 10:24 ` Pasi Kärkkäinen
@ 2005-09-19 12:27 ` Pasi Kärkkäinen
  2005-09-20 10:39 ` Paul Mackerras
  2005-09-26 10:00 ` Pasi Kärkkäinen
  4 siblings, 0 replies; 6+ messages in thread
From: Pasi Kärkkäinen @ 2005-09-19 12:27 UTC (permalink / raw)
  To: linux-ppp

On Tue, Sep 13, 2005 at 01:24:37PM +0300, Pasi Kärkkäinen wrote:
> On Mon, Aug 29, 2005 at 01:10:20PM +1000, Paul Mackerras wrote:
> > I have just put ppp-2.4.4b1.tar.gz on the samba.org ftp server at:
> > 
> > ftp://ftp.samba.org/pub/ppp/ppp-2.4.4b1.tar.gz
> > 
> > This is mostly a bug-fix release, with many bugs fixed to do with
> > persist mode and demand dialling.  The one new feature is that pppd
> > now runs an /etc/ppp/ip-pre-up script after creating the ppp interface
> > and putting the negotiated IP addresses on it but before marking it
> > up.  Since pppd waits for this script to finish, it must run quickly.
> > 
> > Please test.  If there are no problems with it, I will re-release it
> > as ppp-2.4.4 final.
> >
> 
> Hi!
> 
> Could you please add this patch to pppd?
>

I wonder if I am in some kind of blocklist or so.. please comment about this
patch!

I've asked this many times already, and it would be nice to know if you want
something changed.. or don't like the whole thing. Thanks.

-- Pasi Kärkkäinen
 
> http://nrg.joroinen.fi/ppp/pppd-2.4.3-radius-dns-wins-1.diff
> 
> It adds support for fetching dns- and wins-server information from radius..
> If radius server does not reply with dns/wins information, the values from
> the pppd configuration file are used.
> 
> Or if there's something in this patch you'd like to be changed, please tell me.
> 
> Thanks!
> 
> -- Pasi Kärkkäinen
>  

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: ppp-2.4.4b1 released
  2005-08-29  3:10 ppp-2.4.4b1 released Paul Mackerras
                   ` (2 preceding siblings ...)
  2005-09-19 12:27 ` Pasi Kärkkäinen
@ 2005-09-20 10:39 ` Paul Mackerras
  2005-09-26 10:00 ` Pasi Kärkkäinen
  4 siblings, 0 replies; 6+ messages in thread
From: Paul Mackerras @ 2005-09-20 10:39 UTC (permalink / raw)
  To: linux-ppp

Pasi Kärkkäinen writes:

> I wonder if I am in some kind of blocklist or so.. 

No, it's just that ppp is a lower priority for me than some of the
other things I have to do.

> please comment about this
> patch!

I don't like the gratuitous and incorrect whitespace changes.

You are calling the dns and wins hooks in ipcp_resetci, which means
they will get called every time ipcp negotiation is started - is this
what you meant?  Surely they only need to get called once, after the
user is authenticated?

In radius_set_dns and radius_set_wins you compute a return value which
is then never used - why do you bother?

Paul.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: ppp-2.4.4b1 released
  2005-08-29  3:10 ppp-2.4.4b1 released Paul Mackerras
                   ` (3 preceding siblings ...)
  2005-09-20 10:39 ` Paul Mackerras
@ 2005-09-26 10:00 ` Pasi Kärkkäinen
  4 siblings, 0 replies; 6+ messages in thread
From: Pasi Kärkkäinen @ 2005-09-26 10:00 UTC (permalink / raw)
  To: linux-ppp

On Tue, Sep 20, 2005 at 08:39:40PM +1000, Paul Mackerras wrote:
> Pasi Kärkkäinen writes:
> 
> > I wonder if I am in some kind of blocklist or so.. 
> 
> No, it's just that ppp is a lower priority for me than some of the
> other things I have to do.
>

OK. Thanks for the reply :)
 
> > please comment about this
> > patch!
> 
> I don't like the gratuitous and incorrect whitespace changes.
> 

Hmm.. I'll remove those.

> You are calling the dns and wins hooks in ipcp_resetci, which means
> they will get called every time ipcp negotiation is started - is this
> what you meant?  Surely they only need to get called once, after the
> user is authenticated?
> 
> In radius_set_dns and radius_set_wins you compute a return value which
> is then never used - why do you bother?
> 

I'll fix these and send new patch.. 

-- Pasi Kärkkäinen
       
                                   ^
                                .     .
                                 Linux
                              /    -    \
                             Choice.of.the
                           .Next.Generation.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2005-09-26 10:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-29  3:10 ppp-2.4.4b1 released Paul Mackerras
2005-08-29  4:19 ` James Cameron
2005-09-13 10:24 ` Pasi Kärkkäinen
2005-09-19 12:27 ` Pasi Kärkkäinen
2005-09-20 10:39 ` Paul Mackerras
2005-09-26 10:00 ` Pasi Kärkkäinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).