From: "Marco d'Itri" <md@linux.it>
To: linux-ppp@vger.kernel.org
Subject: [patch 07/14] fix segfault in update_db_entry()
Date: Sun, 19 Aug 2007 01:37:47 +0000 [thread overview]
Message-ID: <20070819014009.424487957@bongo.bofh.it> (raw)
From: Martin.Lottermoser@t-online.de
Subject: [patch 07/14] Bug#308136: Debian bug 308136 (SEGV in pppd)
The function update_db_entry() may only be called if pppdb is not NULL;
unfortunately in this situation it is. Other calls to update_db_entry()
are protected against this, see, e.g., the end of script_setenv().
--- a/pppd/main.c
+++ b/pppd/main.c
@@ -1942,9 +1942,11 @@ script_setenv(var, value, iskey)
free(p-1);
script_env[i] = newstring;
#ifdef USE_TDB
- if (iskey && pppdb != NULL)
- add_db_key(newstring);
- update_db_entry();
+ if (pppdb != NULL) {
+ if (iskey)
+ add_db_key(newstring);
+ update_db_entry();
+ }
#endif
return;
}
--
ciao,
Marco
reply other threads:[~2007-08-19 1:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070819014009.424487957@bongo.bofh.it \
--to=md@linux.it \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).