Re: [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc()

Dan Carpenter
2014-12-05T13:57:23Z

On Fri, Dec 05, 2014 at 01:44:30PM +0100, SF Markus Elfring wrote:
> >> The data structure element "arc4" was assigned a null pointer by the
> >> mppe_alloc() function if a previous function call "crypto_alloc_blkcipher"
> >> failed.
> >
> > crypto_alloc_blkcipher() returns error pointers and not NULL.
>
> That is true.
>

Oh. In that case, I misunderstood what you wrote. Looking at it now,
this patch is actually ok.

regards,
dan carpenter