From: Paul Mackerras <paulus@ozlabs.org>
To: linux-ppp@vger.kernel.org
Subject: Re: [PATCH 4/9] pppd: include time.h before using time_t
Date: Thu, 03 Oct 2019 22:40:54 +0000 [thread overview]
Message-ID: <20191003224054.GA26158@blackberry> (raw)
In-Reply-To: <1569482466-9551-5-git-send-email-dev.kurt@vandijck-laurijssen.be>
On Thu, Sep 26, 2019 at 09:21:01AM +0200, Kurt Van Dijck wrote:
> Signed-off-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> ---
> include/net/ppp_defs.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/net/ppp_defs.h b/include/net/ppp_defs.h
> index b06eda5..ed04486 100644
> --- a/include/net/ppp_defs.h
> +++ b/include/net/ppp_defs.h
> @@ -35,6 +35,8 @@
> * OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
> */
>
> +#include <time.h>
> +
> #ifndef _PPP_DEFS_H_
> #define _PPP_DEFS_H_
I applied this series, but then reverted this one because it breaks
compilation of the kernel device driver on Solaris. What exactly is
the error that you are seeing without this #include? Would your error
be fixed by including <sys/time.h> (which would be OK on Solaris)?
Paul.
next prev parent reply other threads:[~2019-10-03 22:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 7:21 [PATCH 4/9] pppd: include time.h before using time_t Kurt Van Dijck
2019-10-03 22:40 ` Paul Mackerras [this message]
2019-10-04 7:06 ` Kurt Van Dijck
2019-10-04 8:22 ` Levente
2019-10-04 10:49 ` Kurt Van Dijck
2019-10-04 12:52 ` James Carlson
2019-10-04 14:29 ` Kurt Van Dijck
2019-10-04 14:49 ` James Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003224054.GA26158@blackberry \
--to=paulus@ozlabs.org \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox