From: "Arnd Bergmann" <arnd@arndb.de>
To: "Qingfang Deng" <dqfext@gmail.com>
Cc: linux-ppp@vger.kernel.org, rp-pppoe@lists.skoll.ca,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"James Chapman" <jchapman@katalix.com>,
"Simon Horman" <horms@kernel.org>,
Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"Michal Ostrowski" <mostrows@gmail.com>,
"Dianne Skoll" <dianne@skoll.ca>,
"Paul Mackerras" <paulus@ozlabs.org>,
"Jaco Kroon" <jaco@uls.co.za>,
"James Carlson" <carlsonj@workingcode.com>,
"Guillaume Nault" <gnault@redhat.com>
Subject: Re: [PATCH RFC net-next] pppoe: remove unused kernel-mode relay support
Date: Wed, 11 Feb 2026 10:11:29 +0100 [thread overview]
Message-ID: <5bcf374e-1259-4f0f-b9a1-d405d522effc@app.fastmail.com> (raw)
In-Reply-To: <CALW65ja3sumAh3uzD3W=n=3Rk0J7EDtcpbvdaG6+F2y2dFUp2Q@mail.gmail.com>
On Wed, Feb 11, 2026, at 10:00, Qingfang Deng wrote:
> On Wed, Feb 11, 2026 at 4:41 PM Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> This will lose all compat ioctl support, not just the emulation for
>> PPPOEIOCSFWD.
>
> So I should only remove the if condition while keeping the
> .compat_ioctl, is that correct?
Yes, exactly. Specifically this will keep the translation for
PPPIOCGMRU, PPPIOCSMRU, PPPIOCSFLAGS, and PPPIOCGL2TPSTATS
socket ioctls, which don't need any translation.
Arnd
prev parent reply other threads:[~2026-02-11 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 7:55 [PATCH RFC net-next] pppoe: remove unused kernel-mode relay support Qingfang Deng
2026-02-11 8:32 ` Arnd Bergmann
2026-02-11 9:00 ` Qingfang Deng
2026-02-11 9:11 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bcf374e-1259-4f0f-b9a1-d405d522effc@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andrew+netdev@lunn.ch \
--cc=carlsonj@workingcode.com \
--cc=davem@davemloft.net \
--cc=dianne@skoll.ca \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=jaco@uls.co.za \
--cc=jchapman@katalix.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=mostrows@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulus@ozlabs.org \
--cc=rp-pppoe@lists.skoll.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox