From: Qingfang Deng <qingfang.deng@linux.dev>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Jiri Kosina <jikos@kernel.org>,
David Sterba <dsterba@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Chas Williams <3chas3@gmail.com>, Simon Horman <horms@kernel.org>,
James Chapman <jchapman@katalix.com>, Kees Cook <kees@kernel.org>,
Taegu Ha <hataegu0826@gmail.com>,
Guillaume Nault <gnault@redhat.com>,
Eric Woudstra <ericwouds@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Dawid Osuchowski <dawid.osuchowski@linux.intel.com>,
Breno Leitao <leitao@debian.org>,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-atm-general@lists.sourceforge.net
Subject: Re: [PATCH net-next 2/3] ppp: unify two channel structs
Date: Thu, 7 May 2026 16:59:42 +0800 [thread overview]
Message-ID: <6ad7864c-b320-4b40-b627-41a986d60ecd@linux.dev> (raw)
In-Reply-To: <20260507084645.mpK7rdPn@linutronix.de>
On 2026/5/7 16:46, Sebastian Andrzej Siewior wrote:
> On 2026-05-07 16:33:36 [+0800], Qingfang Deng wrote:
>> On 2026/5/7 15:40, Sebastian Andrzej Siewior wrote:
>>> On 2026-05-07 13:53:30 [+0800], Qingfang Deng wrote:
>>>>> This patch is IMHO a bit too big and should be split. Also this kind of
>>>>> refactor looks very invasive and potentially regression prone. I think
>>>>> it should include a signficant self-test coverage increase.
>>>> This is indeed too big. But how do I split it without breaking the build?
>>> The current ppp tests would yell if you accidentally broke something?
>> By "breaking the build" I meant compile-time errors (due to API changes).
> If this change would flip the logic somewhere and as such break ppp at
> runtime.
> Would the existing test suite be able to catch it?
The current self-test only covers PPP async and PPPoE, and that's why
Paolo suggests more self-tests.
next prev parent reply other threads:[~2026-05-07 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 9:05 [PATCH net-next 1/3] ppp: use file.dead to check channel unregistration Qingfang Deng
2026-04-30 9:05 ` [PATCH net-next 2/3] ppp: unify two channel structs Qingfang Deng
2026-05-05 11:16 ` Paolo Abeni
2026-05-07 5:53 ` Qingfang Deng
2026-05-07 7:32 ` Paolo Abeni
2026-05-07 7:40 ` Sebastian Andrzej Siewior
2026-05-07 8:33 ` Qingfang Deng
2026-05-07 8:46 ` Sebastian Andrzej Siewior
2026-05-07 8:59 ` Qingfang Deng [this message]
2026-04-30 9:05 ` [PATCH net-next 3/3] docs: update ppp_generic.rst for API changes Qingfang Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ad7864c-b320-4b40-b627-41a986d60ecd@linux.dev \
--to=qingfang.deng@linux.dev \
--cc=3chas3@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=dawid.osuchowski@linux.intel.com \
--cc=dsterba@suse.com \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=gnault@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hataegu0826@gmail.com \
--cc=horms@kernel.org \
--cc=jchapman@katalix.com \
--cc=jikos@kernel.org \
--cc=jirislaby@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox