From: Thomas Chen <tchen@on-go.com>
To: linux-ppp@vger.kernel.org
Subject: Re: ppp MULTILINK issue / problem
Date: Mon, 19 Jul 2004 02:05:46 +0000 [thread overview]
Message-ID: <BD20A530.180A%tchen@on-go.com> (raw)
In-Reply-To: <BCBD226C.57C%tchen@on-go.com>
on 7/16/04 9:22 AM, Matthew N. Dodd at mdodd@patton.com wrote:
i am not sure this is a good fix....
first of all, what version of ppp is this applicable to ?
also, i put this fix in, and for single link (not multilink)
it did not work (ioctl returning error).... i have not tried
multilink, if it works for multilink, then the fix should be
wrap around with
if (multilink)
{
if (ioctl(ppp_fd, PPPIOCDISCONN) < 0)
error("Couldn't detach from PPP unit %d: %m", ifunit);
}
???
however, there is a PPIOCDETACH a few lines below... does that
not do DISCONN ???
> linux-ppp-owner@vger.kernel.org wrote:
>> Subject: ppp MULTILINK issue / problem
> ...
>> now i am testing "UNBUNDLING" of the link.... if i unplug
>> the one of the modem (not the master link), i do not see
>> the IP traffic anymore, though i do see data on the serial
>> link (i put a serial line monitor on the serial port),
>> but no more IP packets coming out of PPP
> ...
>
> I just ran into this and discovered that PPPIOCDISCONN is never being
> called when pppd brings the link down.
>
> This causes the MP fragmentation queue to stall.
>
> Calling this IOCTL in sys-linux.c:generic_disestablish_ppp() fixes the
> problem for me.
>
> void generic_disestablish_ppp(int dev_fd)
> {
> if (new_style_driver) {
> + if (ioctl(ppp_fd, PPPIOCDISCONN) < 0)
> + error("Couldn't detach from PPP unit %d: %m", ifunit);
> close(ppp_fd);
> ppp_fd = -1;
> if (demand) {
>
> --
> Matthew N. Dodd <mdodd@patton.com>
> Software Engineer, Patton Electronics
> 7622 Rickenbacker Dr., Gaithersburg, MD 20879
> (301) 975-1000x184
>
prev parent reply other threads:[~2004-07-19 2:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-04 14:37 ppp MULTILINK issue / problem Thomas Chen
2004-05-04 14:42 ` James Carlson
2004-05-04 22:45 ` Paul Mackerras
2004-05-04 23:05 ` Thomas Chen
2004-05-04 23:13 ` Paul Mackerras
2004-05-05 11:17 ` James Carlson
2004-07-16 16:22 ` Matthew N. Dodd
2004-07-19 2:05 ` Thomas Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BD20A530.180A%tchen@on-go.com \
--to=tchen@on-go.com \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox