From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5D563A48EB for ; Tue, 12 May 2026 13:58:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778594317; cv=none; b=KlY8CtTeLx7U9X2bxJJ0NBFlFchc0LqEETa3w/WmO2UfTpBzyIuDW/ta4h7NmXr/7p5ptSrqluBLPw1nqt5g5QiZqQXAvov2ZnmvHnYUgOzPSjOAL0c+HWZVg2DV3kLMEPEdSR1CQjdpq+qNIgCT2dOmU0iaJ9bixibrjg5mWLY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778594317; c=relaxed/simple; bh=beBaFWnPlfzZYXJ1j1qcJkPi/P6JOAav2skAWYAtYIs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jIKisEbd8zQ+QencXOUguD0I4UFYfttCz8WXT1BDWFeEqs7a5spejORaIvwKyfW3pC4OWJjUnCehkR7yV3BUJpaG1KpcidmXySXCKjM/7f+2bU9KBdusewV+L2K0N1n4zoBySxtoPWJclH3pr9cRvtgemxSeOo788c55jWwdGzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jSzLwKcp; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z+JckVHu; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jSzLwKcp"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z+JckVHu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778594314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SO7uwB/59cp8ViAfTobce45IfmpXjuBRX6FFhYJ0cN8=; b=jSzLwKcp9fgldejVKvcMNeEDmLeLfC1LCUUzSfOmXr933Ryk668l0oCyI/Q14V71s489pl /rHNwXd2Ftcbgc5JioIjfW2sfISg8sdZ0meTCEV8Durp6VAsKK39hckxzG/w882TrXWYB1 gnqviz5tpJr/Cq6PtM8YsNQR85h72WU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-kuGG5LWzNwuaBXUp3ovdKQ-1; Tue, 12 May 2026 09:58:32 -0400 X-MC-Unique: kuGG5LWzNwuaBXUp3ovdKQ-1 X-Mimecast-MFC-AGG-ID: kuGG5LWzNwuaBXUp3ovdKQ_1778594311 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-486fa07f2bbso33543785e9.2 for ; Tue, 12 May 2026 06:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778594311; x=1779199111; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SO7uwB/59cp8ViAfTobce45IfmpXjuBRX6FFhYJ0cN8=; b=Z+JckVHun0brI6fyU7IB4ax+adM0D8DdoHpbGyoCtaKbgvvoj4GZRB2d4rjpUWjdXs LDeI1hYGE1OAS68OkT2coxO61YScWk9ZgLBDN6KfGLf3H0d81tk9PBlioUfWfVZa4WEz K43yvBX2v6GnGo0VZvaX+MQRoxWBtok8qj9UxzRHk1ia27fiw7LvQJC/W1LcrmN4zG3h jjXzyT7/BSi2DPJx5KvmFp5ocIvlQXu9cAy739LgLpURuqhwMSmJyc85AlG415AY7o5R kA78sceSXIAAghgNVv+UTguaklHyDN0o6oT153Fb0vsCxRrmEEKmQhgm9FSJJZmWfpRr mgiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778594311; x=1779199111; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SO7uwB/59cp8ViAfTobce45IfmpXjuBRX6FFhYJ0cN8=; b=ehd1QdKPdLDxlWPCtz6bLktaJhjPUPCbGx9Z5tkMjEfaSfpepWCoud1DN3l8OWZawJ dCNrIP4WphGmxo1wT8A1yKF6rspb67v7lCqIZSLVkkQRs7f7H46xbM0lT+e/tlPYvKcL 63bmMT1RwH+wM0kjQF8+aG3Q4T8ZhmJWPqnDcHfp48mVzoZTsk6DD6gPmZ62Ze/nZNay IWTuXY2mRSzCq7ihbRvdSbQUhIpTbcKhvzgrqCzWxfU1jDg+Yx5DNr4VDGO7dr89Z20f LudspoBhmLsF6MuiFaPRqF+ZAoF7ZeFvjkxaJj7FIqz9aNAtOuF6IskSxCydzfJEnD9x 0lPQ== X-Gm-Message-State: AOJu0Yy6CFiieOW8FL122nUR+CT37gqXYQFelKnWrAFp+KYMGjqb31Ot ijcVTzH5NknSzCjuWk6wdYOEB8C5lcbNYO94pEeeRlUvEdypa1q8Au8D79HkweL1Hcm6sRWGTVe Fpbds6b0bptkt/D6/MmKuqpWvs8onHwT8zEb0VP+2M3TUJD+OKKC9pOUWN5N+Yg== X-Gm-Gg: Acq92OEx/qwnUYXPtnU3QpmuxDRB1NNxT5Ne1FFzqH6FzumvrvkUsSuB8Jz71IFWiyA QLw3OYrusPav5YforDqKwVZam4hLkG4jCoJyNlfSNUCh+XROSwF+irYrmRhiBtXSX8WzXdGlDRT CX2kXL73Q+t1iIyGbWru/uMh0Z0AgyvRKOqrx5yQKouShYYWcGPPtygll1DcFZyze4Ncht533/I /qopVnUcqYj7suv/kgF35jp8EdeP7tXc45UGagvdWaLvwK/vXq4Bb4UKnBDURKgG1xgeEbIQ5jM Stk5AVgSv3Lh/UUKj2XsGBGTEp/N38eIFmUUSKo+KjVXXgzrZRbRvZFP37p0bshWqkz5WfCC7z7 mYoLQzzSaACuuowmMa2J2V/NmSmdYsWoAutr/N5naS0VfGDasnZacSjA= X-Received: by 2002:a05:600c:3f0f:b0:488:a797:f0ac with SMTP id 5b1f17b1804b1-48e9007290cmr51762765e9.28.1778594311035; Tue, 12 May 2026 06:58:31 -0700 (PDT) X-Received: by 2002:a05:600c:3f0f:b0:488:a797:f0ac with SMTP id 5b1f17b1804b1-48e9007290cmr51762245e9.28.1778594310452; Tue, 12 May 2026 06:58:30 -0700 (PDT) Received: from [192.168.88.32] ([216.128.9.106]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e8f41a8b1sm28490495e9.7.2026.05.12.06.58.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 06:58:29 -0700 (PDT) Message-ID: Date: Tue, 12 May 2026 15:58:28 +0200 Precedence: bulk X-Mailing-List: linux-ppp@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 1/2] net: pppoe: implement GRO/GSO support To: Qingfang Deng , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , David Ahern , Ido Schimmel , Kees Cook , Guillaume Nault , Eric Woudstra , Felix Fietkau , Willem de Bruijn , Kuniyuki Iwashima , Richard Gobert , Jiayuan Chen , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-ppp@vger.kernel.org, Pablo Neira Ayuso , Alexander Lobakin References: <20260509030507.387050-1-qingfang.deng@linux.dev> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260509030507.387050-1-qingfang.deng@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/9/26 5:04 AM, Qingfang Deng wrote: > +static struct sk_buff *pppoe_gso_segment(struct sk_buff *skb, > + netdev_features_t features) > +{ > + struct sk_buff *segs = ERR_PTR(-EINVAL); > + struct packet_offload *ptype; > + struct pppoe_hdr *phdr; > + __be16 orig_type, type; > + int len, nhoff; > + > + skb_reset_network_header(skb); > + nhoff = skb_network_header(skb) - skb_mac_header(skb); > + > + if (unlikely(!pskb_may_pull(skb, PPPOE_SES_HLEN))) > + goto out; > + > + phdr = (struct pppoe_hdr *)skb_network_header(skb); > + type = pppoe_hdr_proto(phdr); > + ptype = gro_find_complete_by_type(type); > + if (!ptype) > + goto out; > + > + orig_type = skb->protocol; > + __skb_pull(skb, PPPOE_SES_HLEN); > + features &= ~(NETIF_F_TSO | NETIF_F_TSO6); As sashiko points out here you need to use NETIF_F_GSO_SOFTWARE. /P