* Incorrect comment about userspace in if_pppox.h
@ 2008-02-17 17:50 Robert P. J. Day
0 siblings, 0 replies; only message in thread
From: Robert P. J. Day @ 2008-02-17 17:50 UTC (permalink / raw)
To: linux-ppp
from if_pppox.h:
...
#ifdef __KERNEL__
#include <linux/if_ether.h>
#include <linux/if.h>
#include <linux/netdevice.h>
#include <asm/semaphore.h>
#include <linux/ppp_channel.h>
#endif /* __KERNEL__ */
#include <linux/if_pppol2tp.h>
/* For user-space programs to pick up these definitions
* which they wouldn't get otherwise without defining __KERNEL__
*/
...
that comment's placing in that header file is confusing, since it's
not clear *what* definitions userspace would be missing if it didn't
define __KERNEL__. i'd be tempted to just toss that comment.
rday
--
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.
http://crashcourse.ca Waterloo, Ontario, CANADA
====================================
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-02-17 17:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-17 17:50 Incorrect comment about userspace in if_pppox.h Robert P. J. Day
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).