[PATCH RESEND 0/9] pwm: Remove unnecessary OOM messages

[PATCH RESEND 0/9] pwm: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message. For example,
k.alloc and v.alloc failures use dump_stack().

These patches were expected to be applied to 3.15-rc1. [1]
However, it is not merged yet, so I resend these patches
based on 3.15-rc2.

[1] http://www.spinics.net/lists/linux-pwm/msg00976.html

Jingoo Han (9):
      pwm: ab8500: Remove unnecessary OOM messages
      pwm: i.MX: Remove unnecessary OOM messages
      pwm: pxa: Remove unnecessary OOM messages
      pwm: renesas-tpu: Remove unnecessary OOM messages
      pwm: spear: Remove unnecessary OOM messages
      pwm: tegra: Remove unnecessary OOM messages
      pwm: pwm-tiecap: Remove unnecessary OOM messages
      pwm: tiehrpwm: Remove unnecessary OOM messages
      pwm: vt8500: Remove unnecessary OOM messages

---
 drivers/pwm/pwm-ab8500.c      |    4 +---
 drivers/pwm/pwm-imx.c         |    4 +---
 drivers/pwm/pwm-pxa.c         |    4 +---
 drivers/pwm/pwm-renesas-tpu.c |    4 +---
 drivers/pwm/pwm-spear.c       |    4 +---
 drivers/pwm/pwm-tegra.c       |    4 +---
 drivers/pwm/pwm-tiecap.c      |    4 +---
 drivers/pwm/pwm-tiehrpwm.c    |    4 +---
 drivers/pwm/pwm-vt8500.c      |    4 +---
 9 files changed, 9 insertions(+), 27 deletions(-)

[PATCH RESEND 1/9] pwm: ab8500: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pwm/pwm-ab8500.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pwm/pwm-ab8500.c b/drivers/pwm/pwm-ab8500.c
index 1d07a6f..9d53e8e 100644
--- a/drivers/pwm/pwm-ab8500.c
+++ b/drivers/pwm/pwm-ab8500.c
@@ -101,10 +101,8 @@ static int ab8500_pwm_probe(struct platform_device *pdev)
 	 * device which is required for ab8500 read and write
 	 */
 	ab8500 = devm_kzalloc(&pdev->dev, sizeof(*ab8500), GFP_KERNEL);
-	if (ab8500 == NULL) {
-		dev_err(&pdev->dev, "failed to allocate memory\n");
+	if (ab8500 == NULL)
 		return -ENOMEM;
-	}
 
 	ab8500->chip.dev = &pdev->dev;
 	ab8500->chip.ops = &ab8500_pwm_ops;
-- 
1.7.10.4

[PATCH RESEND 2/9] pwm: i.MX: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pwm/pwm-imx.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index cc47733..d797c7b 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -241,10 +241,8 @@ static int imx_pwm_probe(struct platform_device *pdev)
 		return -ENODEV;
 
 	imx = devm_kzalloc(&pdev->dev, sizeof(*imx), GFP_KERNEL);
-	if (imx == NULL) {
-		dev_err(&pdev->dev, "failed to allocate memory\n");
+	if (imx == NULL)
 		return -ENOMEM;
-	}
 
 	imx->clk_per = devm_clk_get(&pdev->dev, "per");
 	if (IS_ERR(imx->clk_per)) {
-- 
1.7.10.4

[PATCH RESEND 3/9] pwm: pxa: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pwm/pwm-pxa.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c
index cd356d8..0b312ec 100644
--- a/drivers/pwm/pwm-pxa.c
+++ b/drivers/pwm/pwm-pxa.c
@@ -179,10 +179,8 @@ static int pwm_probe(struct platform_device *pdev)
 		return -EINVAL;
 
 	pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL);
-	if (pwm == NULL) {
-		dev_err(&pdev->dev, "failed to allocate memory\n");
+	if (pwm == NULL)
 		return -ENOMEM;
-	}
 
 	pwm->clk = devm_clk_get(&pdev->dev, NULL);
 	if (IS_ERR(pwm->clk))
-- 
1.7.10.4

[PATCH RESEND 4/9] pwm: renesas-tpu: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pwm/pwm-renesas-tpu.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c
index aff6ba9..cc13ff4 100644
--- a/drivers/pwm/pwm-renesas-tpu.c
+++ b/drivers/pwm/pwm-renesas-tpu.c
@@ -405,10 +405,8 @@ static int tpu_probe(struct platform_device *pdev)
 	int ret;
 
 	tpu = devm_kzalloc(&pdev->dev, sizeof(*tpu), GFP_KERNEL);
-	if (tpu == NULL) {
-		dev_err(&pdev->dev, "failed to allocate driver data\n");
+	if (tpu == NULL)
 		return -ENOMEM;
-	}
 
 	spin_lock_init(&tpu->lock);
 	tpu->pdev = pdev;
-- 
1.7.10.4

[PATCH RESEND 5/9] pwm: spear: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pwm/pwm-spear.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
index cb2d4f0..2daf3a1 100644
--- a/drivers/pwm/pwm-spear.c
+++ b/drivers/pwm/pwm-spear.c
@@ -179,10 +179,8 @@ static int spear_pwm_probe(struct platform_device *pdev)
 	u32 val;
 
 	pc = devm_kzalloc(&pdev->dev, sizeof(*pc), GFP_KERNEL);
-	if (!pc) {
-		dev_err(&pdev->dev, "failed to allocate memory\n");
+	if (!pc)
 		return -ENOMEM;
-	}
 
 	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	pc->mmio_base = devm_ioremap_resource(&pdev->dev, r);
-- 
1.7.10.4

[PATCH RESEND 6/9] pwm: tegra: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pwm/pwm-tegra.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c
index 74298c5..61d86b9 100644
--- a/drivers/pwm/pwm-tegra.c
+++ b/drivers/pwm/pwm-tegra.c
@@ -173,10 +173,8 @@ static int tegra_pwm_probe(struct platform_device *pdev)
 	int ret;
 
 	pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL);
-	if (!pwm) {
-		dev_err(&pdev->dev, "failed to allocate memory\n");
+	if (!pwm)
 		return -ENOMEM;
-	}
 
 	pwm->dev = &pdev->dev;
 
-- 
1.7.10.4

[PATCH RESEND 7/9] pwm: pwm-tiecap: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pwm/pwm-tiecap.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
index 032092c..74efbe7 100644
--- a/drivers/pwm/pwm-tiecap.c
+++ b/drivers/pwm/pwm-tiecap.c
@@ -209,10 +209,8 @@ static int ecap_pwm_probe(struct platform_device *pdev)
 	u16 status;
 
 	pc = devm_kzalloc(&pdev->dev, sizeof(*pc), GFP_KERNEL);
-	if (!pc) {
-		dev_err(&pdev->dev, "failed to allocate memory\n");
+	if (!pc)
 		return -ENOMEM;
-	}
 
 	clk = devm_clk_get(&pdev->dev, "fck");
 	if (IS_ERR(clk)) {
-- 
1.7.10.4

[PATCH RESEND 8/9] pwm: tiehrpwm: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pwm/pwm-tiehrpwm.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
index aee4471..3a31c08 100644
--- a/drivers/pwm/pwm-tiehrpwm.c
+++ b/drivers/pwm/pwm-tiehrpwm.c
@@ -440,10 +440,8 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)
 	u16 status;
 
 	pc = devm_kzalloc(&pdev->dev, sizeof(*pc), GFP_KERNEL);
-	if (!pc) {
-		dev_err(&pdev->dev, "failed to allocate memory\n");
+	if (!pc)
 		return -ENOMEM;
-	}
 
 	clk = devm_clk_get(&pdev->dev, "fck");
 	if (IS_ERR(clk)) {
-- 
1.7.10.4

[PATCH RESEND 9/9] pwm: vt8500: Remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/pwm/pwm-vt8500.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pwm/pwm-vt8500.c b/drivers/pwm/pwm-vt8500.c
index 323125a..652e6b5 100644
--- a/drivers/pwm/pwm-vt8500.c
+++ b/drivers/pwm/pwm-vt8500.c
@@ -211,10 +211,8 @@ static int vt8500_pwm_probe(struct platform_device *pdev)
 	}
 
 	chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);
-	if (chip == NULL) {
-		dev_err(&pdev->dev, "failed to allocate memory\n");
+	if (chip == NULL)
 		return -ENOMEM;
-	}
 
 	chip->chip.dev = &pdev->dev;
 	chip->chip.ops = &vt8500_pwm_ops;
-- 
1.7.10.4

Re: [PATCH RESEND 0/9] pwm: Remove unnecessary OOM messages

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]

On Wed, Apr 23, 2014 at 06:38:09PM +0900, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. For example,
> k.alloc and v.alloc failures use dump_stack().
> 
> These patches were expected to be applied to 3.15-rc1. [1]
> However, it is not merged yet, so I resend these patches
> based on 3.15-rc2.
> 
> [1] http://www.spinics.net/lists/linux-pwm/msg00976.html
> 
> Jingoo Han (9):
>       pwm: ab8500: Remove unnecessary OOM messages
>       pwm: i.MX: Remove unnecessary OOM messages
>       pwm: pxa: Remove unnecessary OOM messages
>       pwm: renesas-tpu: Remove unnecessary OOM messages
>       pwm: spear: Remove unnecessary OOM messages
>       pwm: tegra: Remove unnecessary OOM messages
>       pwm: pwm-tiecap: Remove unnecessary OOM messages
>       pwm: tiehrpwm: Remove unnecessary OOM messages
>       pwm: vt8500: Remove unnecessary OOM messages
> 
> ---
>  drivers/pwm/pwm-ab8500.c      |    4 +---
>  drivers/pwm/pwm-imx.c         |    4 +---
>  drivers/pwm/pwm-pxa.c         |    4 +---
>  drivers/pwm/pwm-renesas-tpu.c |    4 +---
>  drivers/pwm/pwm-spear.c       |    4 +---
>  drivers/pwm/pwm-tegra.c       |    4 +---
>  drivers/pwm/pwm-tiecap.c      |    4 +---
>  drivers/pwm/pwm-tiehrpwm.c    |    4 +---
>  drivers/pwm/pwm-vt8500.c      |    4 +---
>  9 files changed, 9 insertions(+), 27 deletions(-)

All 9 patches applied, thanks.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]