* [PATCH] pwm: pca9685: Add .owner to struct pwm_ops
@ 2013-06-19 17:13 Axel Lin
2013-06-20 11:02 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2013-06-19 17:13 UTC (permalink / raw)
To: Thierry Reding; +Cc: Steffen Trumtrar, linux-pwm
Add missing .owner of struct pwm_ops. This prevents the module from being
removed from underneath its users.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pwm/pwm-pca9685.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
index 2afc904..c9f9e65 100644
--- a/drivers/pwm/pwm-pca9685.c
+++ b/drivers/pwm/pwm-pca9685.c
@@ -199,6 +199,7 @@ static const struct pwm_ops pca9685_pwm_ops = {
.config = pca9685_pwm_config,
.request = pca9685_pwm_request,
.free = pca9685_pwm_free,
+ .owner = THIS_MODULE,
};
static struct regmap_config pca9685_regmap_i2c_config = {
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] pwm: pca9685: Add .owner to struct pwm_ops
2013-06-19 17:13 [PATCH] pwm: pca9685: Add .owner to struct pwm_ops Axel Lin
@ 2013-06-20 11:02 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2013-06-20 11:02 UTC (permalink / raw)
To: Axel Lin; +Cc: Steffen Trumtrar, linux-pwm
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
On Thu, Jun 20, 2013 at 01:13:29AM +0800, Axel Lin wrote:
> Add missing .owner of struct pwm_ops. This prevents the module from being
> removed from underneath its users.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/pwm-pca9685.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
> index 2afc904..c9f9e65 100644
> --- a/drivers/pwm/pwm-pca9685.c
> +++ b/drivers/pwm/pwm-pca9685.c
> @@ -199,6 +199,7 @@ static const struct pwm_ops pca9685_pwm_ops = {
> .config = pca9685_pwm_config,
> .request = pca9685_pwm_request,
> .free = pca9685_pwm_free,
> + .owner = THIS_MODULE,
> };
>
> static struct regmap_config pca9685_regmap_i2c_config = {
Hi Axel,
I've already posted a patch for this (and a few other missing .owner
fields) a few days ago. I've now pushed it to my for-next branch.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-20 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-19 17:13 [PATCH] pwm: pca9685: Add .owner to struct pwm_ops Axel Lin
2013-06-20 11:02 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).