linux-pwm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] pwm: pwm-mxs: Wait for configuration to apply before disabling PWM.
@ 2013-06-26 10:26 Robin van der Gracht
  0 siblings, 0 replies; only message in thread
From: Robin van der Gracht @ 2013-06-26 10:26 UTC (permalink / raw)
  To: thierry.reding; +Cc: linux-pwm, linux-kernel, shawn.guo, robin

We have to be sure that the last configuration has been applied. In most
cases drivers will have set the duty-cycle to 0%. To prevent the PWM
from locking at a 100% duty-cycle, we delay disabling the PWM for a
whole period to make sure any new configuration has been latched.

Signed-off-by: Robin van der Gracht <robin@protonic.nl>
---
 drivers/pwm/pwm-mxs.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
index a53d309..7e1fa0a 100644
--- a/drivers/pwm/pwm-mxs.c
+++ b/drivers/pwm/pwm-mxs.c
@@ -10,6 +10,7 @@
  */
 
 #include <linux/clk.h>
+#include <linux/delay.h>
 #include <linux/err.h>
 #include <linux/io.h>
 #include <linux/kernel.h>
@@ -113,6 +114,12 @@ static int mxs_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
 static void mxs_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
 {
 	struct mxs_pwm_chip *mxs = to_mxs_pwm_chip(chip);
+	unsigned int period;
+
+	/* Ensure latest configuration applied. */
+	period = pwm_get_period(pwm);
+	period = DIV_ROUND_UP(period, NSEC_PER_USEC);
+	usleep_range(period, period + 1000);
 
 	writel(1 << pwm->hwpwm, mxs->base + PWM_CTRL + CLR);
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-06-26 10:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-26 10:26 [PATCH v2] pwm: pwm-mxs: Wait for configuration to apply before disabling PWM Robin van der Gracht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).