From: Joe Perches <joe@perches.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Jingoo Han <jg1.han@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 5/9] pwm: spear: Remove unnecessary OOM messages
Date: Tue, 25 Feb 2014 21:19:17 -0800 [thread overview]
Message-ID: <1393391957.407.1.camel@joe-AO722> (raw)
In-Reply-To: <CAKohpon44tVo7K-tPQns1yfs4pBNy9-vY5UPocrHfSPbQ7M5_A@mail.gmail.com>
On Wed, 2014-02-26 at 10:40 +0530, Viresh Kumar wrote:
> On 26 February 2014 10:27, Jingoo Han <jg1.han@samsung.com> wrote:
> > On Wednesday, February 26, 2014 1:49 PM, Viresh Kumar wrote:
> >> On 26 February 2014 06:39, Jingoo Han <jg1.han@samsung.com> wrote:
> >> > The site-specific OOM messages are unnecessary, because they
> >> > duplicate the MM subsystem generic OOM message.
> >> >
> >> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> >> > ---
> >> > drivers/pwm/pwm-spear.c | 4 +---
> >> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >> >
> >> > diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
> >> > index 8ad26b8..b4f6d0d 100644
> >> > --- a/drivers/pwm/pwm-spear.c
> >> > +++ b/drivers/pwm/pwm-spear.c
> >> > @@ -179,10 +179,8 @@ static int spear_pwm_probe(struct platform_device *pdev)
> >> > u32 val;
> >> >
> >> > pc = devm_kzalloc(&pdev->dev, sizeof(*pc), GFP_KERNEL);
> >> > - if (!pc) {
> >> > - dev_err(&pdev->dev, "failed to allocate memory\n");
> >>
> >> Can you please pin point which/file line will print similar message ?
> >
> > (+cc Joe Perches, Andrew Morton)
> >
> > Sorry, I cannot pin point the exact file line.
> > As far as I know, the similar message will be printed,
> > because k.alloc and v.alloc failures use dump_stack().
>
> I have tried tracing calls here and I am unable to find
> any such prints from these routines for majority of
> failure paths. So its better somebody tells me that I am
> wrong here :)
Look at warn_alloc_failed() in mm/page_alloc.c
next prev parent reply other threads:[~2014-02-26 5:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 0:59 [PATCH 0/9] pwm: Remove unnecessary OOM messages Jingoo Han
2014-02-26 1:02 ` [PATCH 1/9] pwm: ab8500: " Jingoo Han
2014-02-26 1:04 ` [PATCH 2/9] pwm: i.MX: " Jingoo Han
2014-02-26 1:06 ` [PATCH 3/9] pwm: pxa: " Jingoo Han
2014-02-26 1:08 ` [PATCH 4/9] pwm: renesas-tpu: " Jingoo Han
2014-02-26 2:22 ` Laurent Pinchart
2014-02-26 2:34 ` Jingoo Han
2014-02-26 22:02 ` Laurent Pinchart
2014-02-26 1:09 ` [PATCH 5/9] pwm: spear: " Jingoo Han
2014-02-26 4:49 ` Viresh Kumar
2014-02-26 4:57 ` Jingoo Han
2014-02-26 5:10 ` Viresh Kumar
2014-02-26 5:19 ` Joe Perches [this message]
2014-02-26 6:26 ` Viresh Kumar
2014-03-03 1:14 ` Jingoo Han
2014-03-03 9:53 ` Dan Carpenter
2014-03-05 11:00 ` Laurent Pinchart
2014-03-05 11:40 ` Dan Carpenter
2014-03-05 16:17 ` Viresh Kumar
2014-03-05 16:29 ` Laurent Pinchart
2014-03-07 8:04 ` Jingoo Han
2014-03-10 12:22 ` Thierry Reding
2014-04-03 3:24 ` Jingoo Han
2014-05-21 10:34 ` Thierry Reding
2014-02-26 1:10 ` [PATCH 6/9] pwm: tegra: " Jingoo Han
2014-02-26 1:12 ` [PATCH 7/9] pwm: pwm-tiecap: " Jingoo Han
2014-02-26 1:13 ` [PATCH 8/9] pwm: tiehrpwm: " Jingoo Han
2014-02-26 1:14 ` [PATCH 9/9] pwm: vt8500: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393391957.407.1.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).