From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: [PATCH 1/2] backlight: show brightness even if get_brightness is not implemented Date: Fri, 30 May 2014 12:10:49 +0200 Message-ID: <1401444650-12267-2-git-send-email-a.hajda@samsung.com> References: <1401444650-12267-1-git-send-email-a.hajda@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1401444650-12267-1-git-send-email-a.hajda@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Lee Jones , Jingoo Han , Bryan Wu Cc: Milo Kim , "open list:FRAMEBUFFER LAYER" , Benjamin Herrenschmidt , "open list:X86 PLATFORM DRIVERS" , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Yijing Wang , Matthew Garrett , Kukjin Kim , Sachin Kamat , Tomi Valkeinen , Geert Uytterhoeven , Daniel Vetter , Jean-Christophe Plagniol-Villard , Dan Carpenter , "open list:PWM SUBSYSTEM" , "moderated list:ARM/S5P EXYNOS AR..." , Mikulas Patocka List-Id: linux-pwm@vger.kernel.org Many implementations of get_brightness operation returns only value of props.brightness field. This change makes such implementations unnecessary. Signed-off-by: Andrzej Hajda --- drivers/video/backlight/backlight.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c index 19b170d..0ce8823 100644 --- a/drivers/video/backlight/backlight.c +++ b/drivers/video/backlight/backlight.c @@ -221,6 +221,8 @@ static ssize_t actual_brightness_show(struct device *dev, mutex_lock(&bd->ops_lock); if (bd->ops && bd->ops->get_brightness) rc = sprintf(buf, "%d\n", bd->ops->get_brightness(bd)); + else + rc = sprintf(buf, "%d\n", bd->props.brightness); mutex_unlock(&bd->ops_lock); return rc; -- 1.9.1