From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Richardson Subject: [PATCH v4 0/3] Fix bugs in kona pwm driver and pwm core Date: Tue, 30 Dec 2014 14:43:27 -0800 Message-ID: <1419979410-7589-1-git-send-email-jonathar@broadcom.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:37161 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbaL3Wnd (ORCPT ); Tue, 30 Dec 2014 17:43:33 -0500 In-Reply-To: Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Tim Kryger Cc: Scott Branden , Arun Ramamurthy , Thierry Reding , Ray Jui , bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Jonathan Richardson This patchset fixes a number of bugs in the Broadcom Kona pwm driver. It also fixes a bug in the pwm core where the state was incorrect on failed calls to enable. Changes from v3: - Removed setting the pwm set to disabled if enable fails. This is now done in the pwm core. - Removed previous change in kona_pwmc_config() that returned right away if the state was disabled. The loop needs to execute to ensure that the period and duty cycle are valid. Delaying this check to when the pwm is enabled is incorrect. - Added comments to clarify code. - Changed commit messages to more accurately reflect the code changes. Jonathan Richardson (3): pwm: kona: Fix incorrect config, disable, and polarity procedures pwm: kona: Remove setting default smooth type and polarity for all channels pwm: core: Set enable state properly on failed call to enable drivers/pwm/core.c | 10 +++- drivers/pwm/pwm-bcm-kona.c | 116 ++++++++++++++++++++++++++++++++++++-------- 2 files changed, 104 insertions(+), 22 deletions(-) -- 1.7.9.5