From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 4/9] pwm: renesas-tpu: Remove unnecessary OOM messages Date: Wed, 26 Feb 2014 03:22:12 +0100 Message-ID: <1426883.W6NvH3R36B@avalon> References: <000701cf328e$00ed24c0$02c76e40$%han@samsung.com> <000c01cf328f$376b8860$a6429920$%han@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:40149 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbaBZCU5 (ORCPT ); Tue, 25 Feb 2014 21:20:57 -0500 In-Reply-To: <000c01cf328f$376b8860$a6429920$%han@samsung.com> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Jingoo Han Cc: 'Thierry Reding' , linux-pwm@vger.kernel.org, 'Laurent Pinchart' , 'Simon Horman' Hi Jingoo, Thank you for the patch. On Wednesday 26 February 2014 10:08:10 Jingoo Han wrote: > The site-specific OOM messages are unnecessary, because they > duplicate the MM subsystem generic OOM message. While an allocation failure for such a small piece of memory will mean that we're in trouble far too big for an error message to matter, have you made sure that all devm_kzalloc() error paths lead to an OOM message being printed ? > Signed-off-by: Jingoo Han > --- > drivers/pwm/pwm-renesas-tpu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c > index aff6ba9..cc13ff4 100644 > --- a/drivers/pwm/pwm-renesas-tpu.c > +++ b/drivers/pwm/pwm-renesas-tpu.c > @@ -405,10 +405,8 @@ static int tpu_probe(struct platform_device *pdev) > int ret; > > tpu = devm_kzalloc(&pdev->dev, sizeof(*tpu), GFP_KERNEL); > - if (tpu == NULL) { > - dev_err(&pdev->dev, "failed to allocate driver data\n"); > + if (tpu == NULL) > return -ENOMEM; > - } > > spin_lock_init(&tpu->lock); > tpu->pdev = pdev; -- Regards, Laurent Pinchart