From: Jonathan Richardson <jonathar@broadcom.com>
To: Tim Kryger <tim.kryger@gmail.com>,
Dmitry Torokhov <dtor@google.com>,
Anatol Pomazau <anatol@google.com>,
Arun Ramamurthy <arun.ramamurthy@broadcom.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Scott Branden <sbranden@broadcom.com>,
Jonathan Richardson <jonathar@broadcom.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: [PATCH v9 0/2] Fix bugs in kona pwm driver and pwm core
Date: Mon, 15 Jun 2015 14:21:00 -0700 [thread overview]
Message-ID: <1434403262-24198-1-git-send-email-jonathar@broadcom.com> (raw)
This patchset fixes a bug in the Broadcom Kona pwm driver. A new procedure for
changing the pwm settings has been introduced. Also fixed a bug in the pwm core
where the enabled state was incorrect on failed calls to enable.
These changes are required for the Kona PWM driver to work on Cygnus. The same
PWM IP is being used.
Changes from v8:
- Accepted patches not included. Patch to introduce debug statements to config
in kona pwm driver not included - will be addressed later.
- Added mutex to pwm core enable function to prevent potential concurrency
issue, as suggested by Thierry.
- Fixed commit message for kona pwm changes. Also changed wording in comments
from enable to trigger.
Changes from v7:
- Polarity changes take effect immediately instead of being deferred until
enable is called.
Changes from v6:
- Move new debugging info for duty cycle and period in config function into
its own commit.
- Add kona_pwmc_prepare_for_settings() function to remove duplicated code.
Changes from v5:
- Address Dmitry's comment on code cleanup of pwm_enable() in pwm core.
- Including all patches from different contributors in this patchset. Some
were left out in v4.
Changes from v4:
- Rebased to Tim Kryger's patch that adds support in pwm core to add driver
with inversed polarity.
- Removed patch 2 that resolved difference between hardware default polarity
and pwm framework default polarity. The default polarity is set properly now
when the pwm driver is registered with the pwm framework.
Jonathan Richardson (2):
pwm: kona: Modify settings application sequence
pwm: core: Set enable state properly on failed call to enable
drivers/pwm/core.c | 19 +++++++++++++++---
drivers/pwm/pwm-bcm-kona.c | 47 +++++++++++++++++++++++++++++++++++---------
include/linux/pwm.h | 2 ++
3 files changed, 56 insertions(+), 12 deletions(-)
--
1.7.9.5
next reply other threads:[~2015-06-15 21:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 21:21 Jonathan Richardson [this message]
2015-06-15 21:21 ` [PATCH v9 1/2] pwm: kona: Modify settings application sequence Jonathan Richardson
2015-07-02 23:36 ` Jonathan Richardson
2015-08-17 14:25 ` Thierry Reding
2015-06-15 21:21 ` [PATCH v9 2/2] pwm: core: Set enable state properly on failed call to enable Jonathan Richardson
2015-06-15 23:22 ` Jonathan Richardson
2015-08-17 14:31 ` Thierry Reding
2015-10-16 18:27 ` Jonathan Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434403262-24198-1-git-send-email-jonathar@broadcom.com \
--to=jonathar@broadcom.com \
--cc=anatol@google.com \
--cc=arun.ramamurthy@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dtor@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
--cc=tim.kryger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).