From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH v2] pwm-backlight: fix the panel power sequence Date: Thu, 29 Oct 2015 16:40:59 +0100 Message-ID: <1446133259.3274.52.camel@pengutronix.de> References: <1444987060-48202-1-git-send-email-yh.huang@mediatek.com> <1444988219.3541.3.camel@pengutronix.de> <1445526750.27586.8.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:34857 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171AbbJ2PlG (ORCPT ); Thu, 29 Oct 2015 11:41:06 -0400 In-Reply-To: <1445526750.27586.8.camel@mtksdaap41> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: YH Huang Cc: Thierry Reding , Jingoo Han , Lee Jones , Matthias Brugger , linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tomi Valkeinen , linux-mediatek@lists.infradead.org, Sascha Hauer , yingjoe.chen@mediatek.com, Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org Hi YH, Am Donnerstag, den 22.10.2015, 23:12 +0800 schrieb YH Huang: > In the case of the panel disabled by the bootloader, > your patch still has the following code and always enables the backlight > in the probe function. > pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable", > - GPIOD_OUT_HIGH); You are right. > What do you think if I remove these two lines in my patch? > if (pb->enable_gpio) > gpiod_direction_output(pb->enable_gpio, 0); That won't work if the gpio is still configured as input. How about I add the GPIOD_ASIS change to my patch you remove that and the above from yours? best regards Philipp