From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: kernel@stlinux.com, maxime.coquelin@st.com,
linux-pwm@vger.kernel.org, thierry.reding@gmail.com,
ajitpal.singh@st.com, Lee Jones <lee.jones@linaro.org>
Subject: [[PATCH v2] 09/11] pwm: sti: Add support for PWM Capture IRQs
Date: Fri, 22 Apr 2016 11:18:13 +0100 [thread overview]
Message-ID: <1461320295-20414-10-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1461320295-20414-1-git-send-email-lee.jones@linaro.org>
Here we're requesting the PWM Capture IRQ and supplying the
handler which will be called in the event of an IRQ fire to
handle it.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/pwm/pwm-sti.c | 92 ++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 91 insertions(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c
index 9d597bb..2230afb 100644
--- a/drivers/pwm/pwm-sti.c
+++ b/drivers/pwm/pwm-sti.c
@@ -91,7 +91,9 @@ struct sti_pwm_chip {
struct regmap_field *prescale_low;
struct regmap_field *prescale_high;
struct regmap_field *pwm_out_en;
+ struct regmap_field *pwm_cpt_en;
struct regmap_field *pwm_cpt_int_en;
+ struct regmap_field *pwm_cpt_int_stat;
struct pwm_chip chip;
struct pwm_device *cur;
unsigned long configured;
@@ -311,6 +313,76 @@ static const struct pwm_ops sti_pwm_ops = {
.owner = THIS_MODULE,
};
+static irqreturn_t sti_pwm_interrupt(int irq, void *data)
+{
+ struct sti_pwm_chip *pc = data;
+ struct device *dev = pc->dev;
+ struct sti_cpt_ddata *ddata;
+ int devicenum;
+ unsigned int cpt_int_stat;
+ unsigned int reg;
+ int ret = IRQ_NONE;
+
+ ret = regmap_field_read(pc->pwm_cpt_int_stat, &cpt_int_stat);
+ if (ret)
+ return ret;
+
+ while (cpt_int_stat) {
+ devicenum = ffs(cpt_int_stat) - 1;
+
+ ddata = pwm_get_chip_data(&pc->chip.pwms[devicenum]);
+
+ /*
+ * Capture input:
+ * _______ _______
+ * | | | |
+ * __| |_________________| |________
+ * ^0 ^1 ^2
+ *
+ * Capture start by the first available rising edge
+ * When a capture event occurs, capture value (CPT_VALx)
+ * is stored, index incremented, capture edge changed.
+ *
+ * After the capture, if the index > 1, we have collected
+ * the necessary data so we signal the thread waiting for it
+ * and disable the capture by setting capture edge to none
+ *
+ */
+
+ regmap_read(pc->regmap,
+ PWM_CPT_VAL(devicenum),
+ &ddata->snapshot[ddata->index]);
+
+ switch (ddata->index) {
+ case 0:
+ case 1:
+ regmap_read(pc->regmap, PWM_CPT_EDGE(devicenum), ®);
+ reg ^= PWM_CPT_EDGE_MASK;
+ regmap_write(pc->regmap, PWM_CPT_EDGE(devicenum), reg);
+
+ ddata->index++;
+ break;
+ case 2:
+ regmap_write(pc->regmap,
+ PWM_CPT_EDGE(devicenum),
+ CPT_EDGE_DISABLED);
+ wake_up(&ddata->wait);
+ break;
+ default:
+ dev_err(dev, "Internal error\n");
+ }
+
+ cpt_int_stat &= ~BIT_MASK(devicenum);
+
+ ret = IRQ_HANDLED;
+ }
+
+ /* Just ACK everything */
+ regmap_write(pc->regmap, PWM_INT_ACK, PWM_INT_ACK_MASK);
+
+ return ret;
+}
+
static int sti_pwm_probe_dt(struct sti_pwm_chip *pc)
{
struct device *dev = pc->dev;
@@ -351,6 +423,11 @@ static int sti_pwm_probe_dt(struct sti_pwm_chip *pc)
if (IS_ERR(pc->pwm_cpt_int_en))
return PTR_ERR(pc->pwm_cpt_int_en);
+ pc->pwm_cpt_int_stat = devm_regmap_field_alloc(dev, pc->regmap,
+ reg_fields[PWM_CPT_INT_STAT]);
+ if (PTR_ERR_OR_ZERO(pc->pwm_cpt_int_stat))
+ return PTR_ERR(pc->pwm_cpt_int_stat);
+
return 0;
}
@@ -367,7 +444,7 @@ static int sti_pwm_probe(struct platform_device *pdev)
struct sti_pwm_chip *pc;
struct resource *res;
unsigned int devnum;
- int ret;
+ int irq, ret;
pc = devm_kzalloc(dev, sizeof(*pc), GFP_KERNEL);
if (!pc)
@@ -388,6 +465,19 @@ static int sti_pwm_probe(struct platform_device *pdev)
if (IS_ERR(pc->regmap))
return PTR_ERR(pc->regmap);
+ irq = platform_get_irq(pdev, 0);
+ if (irq < 0) {
+ dev_err(&pdev->dev, "Failed to obtain IRQ\n");
+ return irq;
+ }
+
+ ret = devm_request_irq(&pdev->dev, irq, sti_pwm_interrupt,
+ 0, pdev->name, pc);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "Failed to request IRQ\n");
+ return ret;
+ }
+
/*
* Setup PWM data with default values: some values could be replaced
* with specific ones provided from Device Tree.
--
2.8.0
next prev parent reply other threads:[~2016-04-22 10:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 10:18 [PATCH v2 00/11] pwm: Add support for PWM Capture Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 01/11] pwm: Add PWM Capture support Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 02/11] pwm: sti: Rename channel => device Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 03/11] pwm: sysfs: Add PWM Capture support Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 04/11] pwm: sti: Reorganise register names in preparation for new functionality Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 05/11] pwm: sti: Only request clock rate when you need to Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 06/11] pwm: sti: Supply PWM Capture register addresses and bit locations Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 07/11] pwm: sti: Supply PWM Capture clock handling Lee Jones
2016-06-07 8:12 ` [STLinux Kernel] " Peter Griffin
2016-04-22 10:18 ` [[PATCH v2] 08/11] pwm: sti: Initialise PWM Capture device data Lee Jones
2016-06-07 8:28 ` [STLinux Kernel] " Peter Griffin
2016-06-07 8:58 ` Lee Jones
2016-06-07 10:47 ` Peter Griffin
2016-06-07 13:29 ` Lee Jones
2016-06-07 15:30 ` Peter Griffin
2016-04-22 10:18 ` Lee Jones [this message]
2016-06-07 8:14 ` [STLinux Kernel] [[PATCH v2] 09/11] pwm: sti: Add support for PWM Capture IRQs Peter Griffin
2016-06-07 9:03 ` Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 10/11] pwm: sti: Add PWM Capture call-back Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 11/11] pwm: sti: Take the opportunity to conduct a little house keeping Lee Jones
2016-04-29 7:40 ` [PATCH v2 00/11] pwm: Add support for PWM Capture Boris Brezillon
2016-06-06 15:32 ` Lee Jones
2016-06-06 18:46 ` Boris Brezillon
2016-06-07 7:46 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461320295-20414-10-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=ajitpal.singh@st.com \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).