From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: linux-pwm@vger.kernel.org, kernel@stlinux.com,
ajitpal.singh@st.com, thierry.reding@gmail.com,
Lee Jones <lee.jones@linaro.org>,
maxime.coquelin@st.com
Subject: [[PATCH v2] 01/11] pwm: Add PWM Capture support
Date: Fri, 22 Apr 2016 11:18:05 +0100 [thread overview]
Message-ID: <1461320295-20414-2-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1461320295-20414-1-git-send-email-lee.jones@linaro.org>
Supply a PWM Capture call-back Op in order to pass back
information obtained by running analysis on PWM a signal.
This would normally (at least during testing) be called from
the Sysfs routines with a view to printing out PWM Capture
data which has been encoded into a string.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/pwm/core.c | 27 +++++++++++++++++++++++++++
include/linux/pwm.h | 28 ++++++++++++++++++++++++++++
2 files changed, 55 insertions(+)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 7831bc6..160784d 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -494,6 +494,33 @@ unlock:
EXPORT_SYMBOL_GPL(pwm_set_polarity);
/**
+ * pwm_capture() - capture and report a PWM signal
+ * @pwm: PWM device
+ * @result: struct to fill with capture result
+ * @timeout_ms: time to wait, in milliseconds, before giving up on capture
+ *
+ * Returns: 0 on success or a negative error code on failure.
+ */
+int pwm_capture(struct pwm_device *pwm, struct pwm_capture *result,
+ unsigned int timeout_ms)
+{
+ int err;
+
+ if (!pwm || !pwm->chip->ops)
+ return -EINVAL;
+
+ if (!pwm->chip->ops->capture)
+ return -ENOSYS;
+
+ mutex_lock(&pwm->lock);
+ err = pwm->chip->ops->capture(pwm->chip, pwm, result, timeout_ms);
+ mutex_unlock(&pwm->lock);
+
+ return err;
+}
+EXPORT_SYMBOL_GPL(pwm_capture);
+
+/**
* pwm_enable() - start a PWM output toggling
* @pwm: PWM device
*
diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index cfc3ed4..49f9648 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -6,6 +6,7 @@
#include <linux/of.h>
struct pwm_device;
+struct pwm_capture;
struct seq_file;
#if IS_ENABLED(CONFIG_PWM)
@@ -33,6 +34,13 @@ int pwm_enable(struct pwm_device *pwm);
* pwm_disable - stop a PWM output toggling
*/
void pwm_disable(struct pwm_device *pwm);
+
+/*
+ * pwm_capture - capture and report a PWM signal
+ */
+int pwm_capture(struct pwm_device *pwm,
+ struct pwm_capture *result,
+ unsigned int timeout_ms);
#else
static inline struct pwm_device *pwm_request(int pwm_id, const char *label)
{
@@ -56,6 +64,13 @@ static inline int pwm_enable(struct pwm_device *pwm)
static inline void pwm_disable(struct pwm_device *pwm)
{
}
+
+static inline int pwm_capture(struct pwm_device *pwm,
+ struct pwm_capture *result,
+ unsigned int timeout_ms)
+{
+ return -EINVAL;
+}
#endif
struct pwm_chip;
@@ -107,6 +122,16 @@ struct pwm_device {
enum pwm_polarity polarity;
};
+/**
+ * struct pwm_capture - PWM capture data
+ * @period: period of the PWM signal (in nanoseconds)
+ * @duty_cycle: duty cycle of the PWM signal (in nanoseconds)
+ */
+struct pwm_capture {
+ unsigned long long period;
+ unsigned long long duty_cycle;
+};
+
static inline bool pwm_is_enabled(const struct pwm_device *pwm)
{
return test_bit(PWMF_ENABLED, &pwm->flags);
@@ -150,6 +175,7 @@ static inline enum pwm_polarity pwm_get_polarity(const struct pwm_device *pwm)
* @free: optional hook for freeing a PWM
* @config: configure duty cycles and period length for this PWM
* @set_polarity: configure the polarity of this PWM
+ * @capture: capture and report PWM signal
* @enable: enable PWM output toggling
* @disable: disable PWM output toggling
* @dbg_show: optional routine to show contents in debugfs
@@ -162,6 +188,8 @@ struct pwm_ops {
int duty_ns, int period_ns);
int (*set_polarity)(struct pwm_chip *chip, struct pwm_device *pwm,
enum pwm_polarity polarity);
+ int (*capture)(struct pwm_chip *chip, struct pwm_device *pwm,
+ struct pwm_capture *result, unsigned int timeout_ms);
int (*enable)(struct pwm_chip *chip, struct pwm_device *pwm);
void (*disable)(struct pwm_chip *chip, struct pwm_device *pwm);
#ifdef CONFIG_DEBUG_FS
--
2.8.0
next prev parent reply other threads:[~2016-04-22 10:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 10:18 [PATCH v2 00/11] pwm: Add support for PWM Capture Lee Jones
2016-04-22 10:18 ` Lee Jones [this message]
2016-04-22 10:18 ` [[PATCH v2] 02/11] pwm: sti: Rename channel => device Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 03/11] pwm: sysfs: Add PWM Capture support Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 04/11] pwm: sti: Reorganise register names in preparation for new functionality Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 05/11] pwm: sti: Only request clock rate when you need to Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 06/11] pwm: sti: Supply PWM Capture register addresses and bit locations Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 07/11] pwm: sti: Supply PWM Capture clock handling Lee Jones
2016-06-07 8:12 ` [STLinux Kernel] " Peter Griffin
2016-04-22 10:18 ` [[PATCH v2] 08/11] pwm: sti: Initialise PWM Capture device data Lee Jones
2016-06-07 8:28 ` [STLinux Kernel] " Peter Griffin
2016-06-07 8:58 ` Lee Jones
2016-06-07 10:47 ` Peter Griffin
2016-06-07 13:29 ` Lee Jones
2016-06-07 15:30 ` Peter Griffin
2016-04-22 10:18 ` [[PATCH v2] 09/11] pwm: sti: Add support for PWM Capture IRQs Lee Jones
2016-06-07 8:14 ` [STLinux Kernel] " Peter Griffin
2016-06-07 9:03 ` Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 10/11] pwm: sti: Add PWM Capture call-back Lee Jones
2016-04-22 10:18 ` [[PATCH v2] 11/11] pwm: sti: Take the opportunity to conduct a little house keeping Lee Jones
2016-04-29 7:40 ` [PATCH v2 00/11] pwm: Add support for PWM Capture Boris Brezillon
2016-06-06 15:32 ` Lee Jones
2016-06-06 18:46 ` Boris Brezillon
2016-06-07 7:46 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461320295-20414-2-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=ajitpal.singh@st.com \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).