* [PATCH] pwm: sysfs: get return value from pwm_apply_state()
@ 2016-06-08 1:58 Yoshihiro Shimoda
2016-06-10 12:25 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Yoshihiro Shimoda @ 2016-06-08 1:58 UTC (permalink / raw)
To: thierry.reding
Cc: ryo.kodama.vz, linux-pwm, linux-renesas-soc, Yoshihiro Shimoda
From: Ryo Kodama <ryo.kodama.vz@renesas.com>
This patch adds to check the return value from pwm_apply_state()
used in enable_store(). The error of enable_store() doesn't work
if the return value doesn't received.
Signed-off-by: Ryo Kodama <ryo.kodama.vz@renesas.com>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
drivers/pwm/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c
index d985992..01695d4 100644
--- a/drivers/pwm/sysfs.c
+++ b/drivers/pwm/sysfs.c
@@ -152,7 +152,7 @@ static ssize_t enable_store(struct device *child,
goto unlock;
}
- pwm_apply_state(pwm, &state);
+ ret = pwm_apply_state(pwm, &state);
unlock:
mutex_unlock(&export->lock);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pwm: sysfs: get return value from pwm_apply_state()
2016-06-08 1:58 [PATCH] pwm: sysfs: get return value from pwm_apply_state() Yoshihiro Shimoda
@ 2016-06-10 12:25 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2016-06-10 12:25 UTC (permalink / raw)
To: Yoshihiro Shimoda; +Cc: ryo.kodama.vz, linux-pwm, linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On Wed, Jun 08, 2016 at 10:58:23AM +0900, Yoshihiro Shimoda wrote:
> From: Ryo Kodama <ryo.kodama.vz@renesas.com>
>
> This patch adds to check the return value from pwm_apply_state()
> used in enable_store(). The error of enable_store() doesn't work
> if the return value doesn't received.
>
> Signed-off-by: Ryo Kodama <ryo.kodama.vz@renesas.com>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> drivers/pwm/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-10 12:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-08 1:58 [PATCH] pwm: sysfs: get return value from pwm_apply_state() Yoshihiro Shimoda
2016-06-10 12:25 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).