From: Lukasz Majewski <l.majewski@majess.pl>
To: Thierry Reding <thierry.reding@gmail.com>,
Stefan Agner <stefan@agner.ch>,
Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Lothar Wassmann <LW@karo-electronics.de>,
Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>,
kernel@pengutronix.de, Lukasz Majewski <l.majewski@majess.pl>
Subject: [PATCH v2 10/10] pwm: imx: Add polarity inversion support to i.MX's PWMv2
Date: Thu, 27 Oct 2016 08:29:45 +0200 [thread overview]
Message-ID: <1477549785-4972-10-git-send-email-l.majewski@majess.pl> (raw)
In-Reply-To: <1477549785-4972-1-git-send-email-l.majewski@majess.pl>
With this patch the polarity settings for i.MX's PWMv2 is now supported
on top of atomic PWM setting
Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>
---
Changes for v2:
- New patch
---
drivers/pwm/pwm-imx.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 0132439a..92b4ba0 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -38,6 +38,7 @@
#define MX3_PWMCR_DOZEEN (1 << 24)
#define MX3_PWMCR_WAITEN (1 << 23)
#define MX3_PWMCR_DBGEN (1 << 22)
+#define MX3_PWMCR_POUTC (1 << 18)
#define MX3_PWMCR_CLKSRC_IPG_HIGH (2 << 16)
#define MX3_PWMCR_CLKSRC_IPG (1 << 16)
#define MX3_PWMCR_SWR (1 << 3)
@@ -234,6 +235,9 @@ static int imx_pwm_apply_v2(struct pwm_chip *chip, struct pwm_device *pwm,
if (state->enabled)
cr |= MX3_PWMCR_EN;
+ if (state->polarity == PWM_POLARITY_INVERSED)
+ cr |= MX3_PWMCR_POUTC;
+
writel(cr, imx->mmio_base + MX3_PWMCR);
/* Disable the clock if the PWM is being disabled. */
@@ -258,6 +262,7 @@ static struct pwm_ops imx_pwm_ops_v2 = {
};
struct imx_pwm_data {
+ bool polarity_supported;
struct pwm_ops *pwm_ops;
};
@@ -266,6 +271,7 @@ static struct imx_pwm_data imx_pwm_data_v1 = {
};
static struct imx_pwm_data imx_pwm_data_v2 = {
+ .polarity_supported = true,
.pwm_ops = &imx_pwm_ops_v2,
};
@@ -313,6 +319,11 @@ static int imx_pwm_probe(struct platform_device *pdev)
imx->chip.base = -1;
imx->chip.npwm = 1;
imx->chip.can_sleep = true;
+ if (data->polarity_supported) {
+ dev_dbg(&pdev->dev, "PWM supports output inversion\n");
+ imx->chip.of_xlate = of_pwm_xlate_with_flags;
+ imx->chip.of_pwm_n_cells = 3;
+ }
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
imx->mmio_base = devm_ioremap_resource(&pdev->dev, r);
--
2.1.4
prev parent reply other threads:[~2016-10-27 6:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 6:29 [PATCH v2 00/10] pwm: imx: Provide atomic operation for IMX PWM driver Lukasz Majewski
2016-10-27 6:29 ` [PATCH v2 01/10] pwm: print error messages with pr_err() instead of pr_debug() Lukasz Majewski
2016-10-27 6:29 ` [PATCH v2 02/10] pwm: imx: Add separate set of pwm ops for PWMv1 and PWMv2 Lukasz Majewski
2016-10-27 6:29 ` [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to facilitate switch to atomic pwm operation Lukasz Majewski
2016-10-27 7:40 ` Boris Brezillon
2016-10-27 8:22 ` Lukasz Majewski
2016-10-31 5:59 ` Sascha Hauer
2016-10-31 8:06 ` Lukasz Majewski
2016-10-31 9:24 ` Sascha Hauer
2016-10-31 9:29 ` Sascha Hauer
2016-10-31 11:58 ` Lukasz Majewski
2016-11-01 5:57 ` Lukasz Majewski
2016-11-01 7:17 ` Sascha Hauer
2016-11-01 8:20 ` Lukasz Majewski
2016-11-01 8:59 ` Sascha Hauer
2016-11-02 7:18 ` Lothar Waßmann
2016-11-02 7:36 ` Sascha Hauer
2016-11-02 7:56 ` Lothar Waßmann
2016-11-02 8:06 ` Sascha Hauer
2016-11-02 8:51 ` Lothar Waßmann
2016-11-02 9:34 ` Philipp Zabel
2016-10-27 6:29 ` [PATCH v2 04/10] pwm: imx: Move PWMv2 software reset code to a separate function Lukasz Majewski
2016-11-03 9:34 ` Philipp Zabel
2016-10-27 6:29 ` [PATCH v2 05/10] pwm: imx: Move PWMv2 wait for fifo slot " Lukasz Majewski
2016-10-27 6:29 ` [PATCH v2 06/10] pwm: imx: Provide atomic PWM support for i.MX PWMv2 Lukasz Majewski
2016-10-27 6:29 ` [PATCH v2 07/10] pwm: imx: Remove redundant i.MX PWMv2 code Lukasz Majewski
2016-10-27 6:29 ` [PATCH v2 08/10] pwm: core: make the PWM_POLARITY flag in DTB optional Lukasz Majewski
2016-10-27 6:29 ` Lukasz Majewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477549785-4972-10-git-send-email-l.majewski@majess.pl \
--to=l.majewski@majess.pl \
--cc=LW@karo-electronics.de \
--cc=bhuvanchandra.dv@toradex.com \
--cc=boris.brezillon@free-electrons.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).