linux-pwm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@majess.pl>
To: Thierry Reding <thierry.reding@gmail.com>,
	Stefan Agner <stefan@agner.ch>,
	Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	Lothar Wassmann <LW@karo-electronics.de>,
	Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>,
	kernel@pengutronix.de, Lukasz Majewski <l.majewski@majess.pl>
Subject: [PATCH v2 04/10] pwm: imx: Move PWMv2 software reset code to a separate function
Date: Thu, 27 Oct 2016 08:29:40 +0200	[thread overview]
Message-ID: <1477549785-4972-5-git-send-email-l.majewski@majess.pl> (raw)
In-Reply-To: <1477549785-4972-1-git-send-email-l.majewski@majess.pl>

The software reset code has been extracted from imx_pwm_config_v2 function
and moved to new one - imx_pwm_sw_reset().

This change reduces the overall size of imx_pwm_config_v2() and prepares
it for atomic PWM operation.

Suggested-by: Stefan Agner <stefan@agner.ch>
Suggested-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Lukasz Majewski <l.majewski@majess.pl>

---
Changes for v2:
- Add missing parenthesis
---
 drivers/pwm/pwm-imx.c | 31 +++++++++++++++++++++----------
 1 file changed, 21 insertions(+), 10 deletions(-)

diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 822eb5a..8174ae6 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -134,6 +134,25 @@ static void imx_pwm_disable_v1(struct pwm_chip *chip, struct pwm_device *pwm)
 	clk_disable_unprepare(imx->clk_per);
 }
 
+static void imx_pwm_sw_reset(struct pwm_chip *chip)
+{
+	struct imx_chip *imx = to_imx_chip(chip);
+	struct device *dev = chip->dev;
+	int wait_count = 0;
+	u32 cr;
+
+	writel(MX3_PWMCR_SWR, imx->mmio_base + MX3_PWMCR);
+	do {
+		usleep_range(200, 1000);
+		cr = readl(imx->mmio_base + MX3_PWMCR);
+	} while ((cr & MX3_PWMCR_SWR) &&
+		 (wait_count++ < MX3_PWM_SWR_LOOP));
+
+	if (cr & MX3_PWMCR_SWR)
+		dev_warn(dev, "software reset timeout\n");
+}
+
+
 static int imx_pwm_config_v2(struct pwm_chip *chip,
 		struct pwm_device *pwm, int duty_ns, int period_ns)
 {
@@ -143,7 +162,7 @@ static int imx_pwm_config_v2(struct pwm_chip *chip,
 	unsigned long period_cycles, duty_cycles, prescale;
 	unsigned int period_ms;
 	bool enable = pwm_is_enabled(pwm);
-	int wait_count = 0, fifoav;
+	int fifoav;
 	u32 cr, sr;
 
 	/*
@@ -166,15 +185,7 @@ static int imx_pwm_config_v2(struct pwm_chip *chip,
 				dev_warn(dev, "there is no free FIFO slot\n");
 		}
 	} else {
-		writel(MX3_PWMCR_SWR, imx->mmio_base + MX3_PWMCR);
-		do {
-			usleep_range(200, 1000);
-			cr = readl(imx->mmio_base + MX3_PWMCR);
-		} while ((cr & MX3_PWMCR_SWR) &&
-			 (wait_count++ < MX3_PWM_SWR_LOOP));
-
-		if (cr & MX3_PWMCR_SWR)
-			dev_warn(dev, "software reset timeout\n");
+		imx_pwm_sw_reset(chip);
 	}
 
 	c = clk_get_rate(imx->clk_per);
-- 
2.1.4

  parent reply	other threads:[~2016-10-27  6:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-27  6:29 [PATCH v2 00/10] pwm: imx: Provide atomic operation for IMX PWM driver Lukasz Majewski
2016-10-27  6:29 ` [PATCH v2 01/10] pwm: print error messages with pr_err() instead of pr_debug() Lukasz Majewski
2016-10-27  6:29 ` [PATCH v2 02/10] pwm: imx: Add separate set of pwm ops for PWMv1 and PWMv2 Lukasz Majewski
2016-10-27  6:29 ` [PATCH v2 03/10] pwm: imx: Rewrite imx_pwm_*_v1 code to facilitate switch to atomic pwm operation Lukasz Majewski
2016-10-27  7:40   ` Boris Brezillon
2016-10-27  8:22     ` Lukasz Majewski
2016-10-31  5:59     ` Sascha Hauer
2016-10-31  8:06       ` Lukasz Majewski
2016-10-31  9:24         ` Sascha Hauer
2016-10-31  9:29       ` Sascha Hauer
2016-10-31 11:58         ` Lukasz Majewski
2016-11-01  5:57         ` Lukasz Majewski
2016-11-01  7:17           ` Sascha Hauer
2016-11-01  8:20             ` Lukasz Majewski
2016-11-01  8:59         ` Sascha Hauer
2016-11-02  7:18       ` Lothar Waßmann
2016-11-02  7:36         ` Sascha Hauer
2016-11-02  7:56           ` Lothar Waßmann
2016-11-02  8:06             ` Sascha Hauer
2016-11-02  8:51               ` Lothar Waßmann
2016-11-02  9:34                 ` Philipp Zabel
2016-10-27  6:29 ` Lukasz Majewski [this message]
2016-11-03  9:34   ` [PATCH v2 04/10] pwm: imx: Move PWMv2 software reset code to a separate function Philipp Zabel
2016-10-27  6:29 ` [PATCH v2 05/10] pwm: imx: Move PWMv2 wait for fifo slot " Lukasz Majewski
2016-10-27  6:29 ` [PATCH v2 06/10] pwm: imx: Provide atomic PWM support for i.MX PWMv2 Lukasz Majewski
2016-10-27  6:29 ` [PATCH v2 07/10] pwm: imx: Remove redundant i.MX PWMv2 code Lukasz Majewski
2016-10-27  6:29 ` [PATCH v2 08/10] pwm: core: make the PWM_POLARITY flag in DTB optional Lukasz Majewski
2016-10-27  6:29 ` [PATCH v2 10/10] pwm: imx: Add polarity inversion support to i.MX's PWMv2 Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477549785-4972-5-git-send-email-l.majewski@majess.pl \
    --to=l.majewski@majess.pl \
    --cc=LW@karo-electronics.de \
    --cc=bhuvanchandra.dv@toradex.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=stefan@agner.ch \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).