From: Lukasz Majewski <l.majewski@majess.pl>
To: Thierry Reding <thierry.reding@gmail.com>,
Stefan Agner <stefan@agner.ch>,
Sascha Hauer <s.hauer@pengutronix.de>,
Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Lothar Wassmann" <LW@karo-electronics.de>,
"Bhuvanchandra DV" <bhuvanchandra.dv@toradex.com>,
kernel@pengutronix.de, "Lukasz Majewski" <l.majewski@majess.pl>,
"Lothar Waßmann" <LW@KARO-electronics.de>
Subject: [PATCH v3 01/11] pwm: print error messages with pr_err() instead of pr_debug()
Date: Tue, 1 Nov 2016 08:10:20 +0100 [thread overview]
Message-ID: <1477984230-18071-2-git-send-email-l.majewski@majess.pl> (raw)
In-Reply-To: <1477984230-18071-1-git-send-email-l.majewski@majess.pl>
From: Lothar Wassmann <LW@KARO-electronics.de>
Make the messages that are printed in case of fatal errors actually
visible to the user without having to recompile the driver with
debugging enabled.
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
---
Changes for v3:
- None
---
drivers/pwm/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 172ef82..ec7179f 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -663,13 +663,13 @@ struct pwm_device *of_pwm_get(struct device_node *np, const char *con_id)
err = of_parse_phandle_with_args(np, "pwms", "#pwm-cells", index,
&args);
if (err) {
- pr_debug("%s(): can't parse \"pwms\" property\n", __func__);
+ pr_err("%s(): can't parse \"pwms\" property\n", __func__);
return ERR_PTR(err);
}
pc = of_node_to_pwmchip(args.np);
if (IS_ERR(pc)) {
- pr_debug("%s(): PWM chip not found\n", __func__);
+ pr_err("%s(): PWM chip not found\n", __func__);
pwm = ERR_CAST(pc);
goto put;
}
--
2.1.4
next prev parent reply other threads:[~2016-11-01 7:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 7:10 [PATCH v3 00/11] pwm: imx: Provide atomic operation for IMX PWM driver Lukasz Majewski
2016-11-01 7:10 ` Lukasz Majewski [this message]
2016-11-01 7:10 ` [PATCH v3 02/11] pwm: imx: remove ipg clock Lukasz Majewski
2016-11-01 9:26 ` Philipp Zabel
2016-11-22 21:04 ` Stefan Agner
2016-11-23 8:43 ` Boris Brezillon
2016-11-28 6:02 ` Lukasz Majewski
2016-11-01 7:10 ` [PATCH v3 03/11] pwm: imx: Add separate set of pwm ops for PWMv1 and PWMv2 Lukasz Majewski
2016-11-01 7:10 ` [PATCH v3 04/11] pwm: imx: Rewrite imx_pwm_*_v1 code to facilitate switch to atomic pwm operation Lukasz Majewski
2016-11-22 21:31 ` Stefan Agner
2016-11-01 7:10 ` [PATCH v3 05/11] pwm: imx: Move PWMv2 software reset code to a separate function Lukasz Majewski
2016-11-22 21:56 ` Stefan Agner
2016-11-01 7:10 ` [PATCH v3 06/11] pwm: imx: Move PWMv2 wait for fifo slot " Lukasz Majewski
2016-11-22 21:56 ` Stefan Agner
2016-11-01 7:10 ` [PATCH v3 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2 Lukasz Majewski
2016-11-22 21:55 ` Stefan Agner
2016-11-23 8:38 ` Boris Brezillon
2016-11-23 19:30 ` Stefan Agner
2016-11-28 5:50 ` Lukasz Majewski
2016-11-28 8:15 ` Boris Brezillon
2016-11-28 20:48 ` Lukasz Majewski
2016-11-29 8:24 ` Boris Brezillon
2016-11-01 7:10 ` [PATCH v3 08/11] pwm: imx: Remove redundant i.MX PWMv2 code Lukasz Majewski
2016-11-01 7:10 ` [PATCH v3 09/11] pwm: core: make the PWM_POLARITY flag in DTB optional Lukasz Majewski
2016-11-01 7:10 ` [PATCH v3 10/11] pwm: imx: doc: Update imx-pwm.txt documentation entry Lukasz Majewski
2016-11-01 7:10 ` [PATCH v3 11/11] pwm: imx: Add polarity inversion support to i.MX's PWMv2 Lukasz Majewski
2016-11-22 22:08 ` Stefan Agner
2016-11-08 22:24 ` [PATCH v3 00/11] pwm: imx: Provide atomic operation for IMX PWM driver Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477984230-18071-2-git-send-email-l.majewski@majess.pl \
--to=l.majewski@majess.pl \
--cc=LW@karo-electronics.de \
--cc=bhuvanchandra.dv@toradex.com \
--cc=boris.brezillon@free-electrons.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).