From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v4 1/1] pwm: pca9685: fix gpio-only operation. Date: Thu, 20 Apr 2017 19:13:11 +0300 Message-ID: <1492704791.24567.104.camel@linux.intel.com> References: <1492088291-5215-1-git-send-email-svenv@arcx.com> <1492088291-5215-2-git-send-email-svenv@arcx.com> <1492506852.24567.54.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sven Van Asbroeck , Andy Shevchenko Cc: Thierry Reding , "Rafael J. Wysocki" , linux-pwm@vger.kernel.org, "linux-kernel@vger.kernel.org" , Mika Westerberg , Sven Van Asbroeck List-Id: linux-pwm@vger.kernel.org On Thu, 2017-04-20 at 11:50 -0400, Sven Van Asbroeck wrote: > > Thus, I would suggest: int sleep -> bool enable (or alike). > > > > Would we agree on that? > > I would. Perhaps also: > set_sleep_mode(int sleep) -> enable_sleep_mode(bool enable) ? I'm okay with a such (don't forget to change 0/1 in call sites to false/true as well). > Let's see what Mika and Thierry think. I suppose Mika's answer is an acknowledge to the change. -- Andy Shevchenko Intel Finland Oy