From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Kamil Debski <kamil@wypas.org>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
linux-pwm@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
b.zolnierkie@samsung.com
Subject: [PATCH v2 1/3] pwm: pwm-samsung: remove redundant checks from pwm_samsung_config()
Date: Mon, 24 Apr 2017 12:01:07 +0200 [thread overview]
Message-ID: <1493028069-32003-2-git-send-email-b.zolnierkie@samsung.com> (raw)
In-Reply-To: <1493028069-32003-1-git-send-email-b.zolnierkie@samsung.com>
If the requested period_ns and duty_ns values are identical to
the last programmed ones pwm_samsung_config() returns early and
skips the hardware configuration. The same checks are now done
by the PWM core so the driver specific ones can be removed.
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
drivers/pwm/pwm-samsung.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
index f113cda..9ea7638 100644
--- a/drivers/pwm/pwm-samsung.c
+++ b/drivers/pwm/pwm-samsung.c
@@ -312,9 +312,6 @@ static int pwm_samsung_config(struct pwm_chip *chip, struct pwm_device *pwm,
if (period_ns > NSEC_PER_SEC)
return -ERANGE;
- if (period_ns == chan->period_ns && duty_ns == chan->duty_ns)
- return 0;
-
tcnt = readl(our_chip->base + REG_TCNTB(pwm->hwpwm));
oldtcmp = readl(our_chip->base + REG_TCMPB(pwm->hwpwm));
--
1.9.1
next prev parent reply other threads:[~2017-04-24 10:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170424100128epcas5p20396f75d5626a320a9eb11d89ae87ac5@epcas5p2.samsung.com>
2017-04-24 10:01 ` [PATCH v2 0/3] pwm: pwm-samsung: fix suspend/resume support Bartlomiej Zolnierkiewicz
[not found] ` <CGME20170424100132epcas1p47ad6d41345962cc43d8f34d5920951bd@epcas1p4.samsung.com>
2017-04-24 10:01 ` Bartlomiej Zolnierkiewicz [this message]
2017-08-21 8:32 ` [PATCH v2 1/3] pwm: pwm-samsung: remove redundant checks from pwm_samsung_config() Thierry Reding
[not found] ` <CGME20170424100135epcas5p28465e84a8517c219cb8a1b719fb1137d@epcas5p2.samsung.com>
2017-04-24 10:01 ` [PATCH v2 2/3] pwm: pwm-samsung: fix suspend/resume support Bartlomiej Zolnierkiewicz
2017-08-21 8:34 ` Thierry Reding
[not found] ` <CGME20170424100139epcas1p4e8e120d2da6ef7eb69ca28f6b3077c59@epcas1p4.samsung.com>
2017-04-24 10:01 ` [PATCH v2 3/3] hwmon: pwm-fan: remove no longer needed suspend/resume code Bartlomiej Zolnierkiewicz
2017-06-29 11:14 ` [PATCH v2 0/3] pwm: pwm-samsung: fix suspend/resume support Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493028069-32003-2-git-send-email-b.zolnierkie@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=jdelvare@suse.com \
--cc=kamil@wypas.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=thierry.reding@gmail.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).