Re: [PATCH] pwm: lpss-platform: Cleanly exit probe on boards without resources

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

+Cc: Mika

On Fri, 2018-01-12 at 12:38 +0100, Hans de Goede wrote:
> Some boards which do not use the pwm-controller have an empty or
> invalid
> resource-table in ACPI the for pwm-controller. Currently this causes
> these
> error messages to get logged:
> [    3.281966] pwm-lpss 80862288:00: invalid resource
> [    3.287098] pwm-lpss: probe of 80862288:00 failed with error -22
> 
> This commit silences these error messages on these boards by cleanly
> exiting pwm_lpss_probe_platform() if there is no memory resource.
> 

I don't see anything wrong with message per se.

> +
> +	/*
> +	 * Some boards which don't use the pwm controller have an
> empty
> +	 * resources table, so if we cannot get the resource, return
> -ENODEV.
> +	 */
>  	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!r)
> +		return -ENODEV;

But this one looks like a quirk for some platforms when other can
survive without.

Can we actually check this in acpi_lpss.c and prevent platform device
registration at all?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy