From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Lukasz Majewski" <l.majewski@majess.pl>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Lothar Waßmann" <LW@karo-electronics.de>,
"Michal Vokáč" <michal.vokac@ysoft.com>
Subject: [RFC PATCH 1/2] dt-bindings: pwm: imx: Allow switching PWM output between PWM and GPIO
Date: Tue, 21 Aug 2018 16:38:52 +0200 [thread overview]
Message-ID: <1534862333-27950-2-git-send-email-michal.vokac@ysoft.com> (raw)
In-Reply-To: <1534862333-27950-1-git-send-email-michal.vokac@ysoft.com>
Output of the PWM block of i.MX SoCs is always zero volts when the block
is disabled. This can caue issues when inverted PWM polarity is needed.
With inverted polarity a duty cycle = 0% corresponds to solid high level
on the output. If the PWM is dissabled its output instantly goes to solid
zero which corresponds to duty cycle = 100%.
To have a trully inverted PWM output configure the PWM pad as a GPIO
with pull-up. Then switch the pad to PWM output whenever non-zero
duty cycle is needed.
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
Documentation/devicetree/bindings/pwm/imx-pwm.txt | 44 +++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.txt b/Documentation/devicetree/bindings/pwm/imx-pwm.txt
index c61bdf8..3b1bc4c 100644
--- a/Documentation/devicetree/bindings/pwm/imx-pwm.txt
+++ b/Documentation/devicetree/bindings/pwm/imx-pwm.txt
@@ -14,6 +14,12 @@ See the clock consumer binding,
Documentation/devicetree/bindings/clock/clock-bindings.txt
- interrupts: The interrupt for the pwm controller
+Optional properties:
+- pinctrl: For i.MX27 and newer SoCs. Add extra pinctrl to configure the PWM
+ pin to gpio function. It allows control over the pin output level when the
+ PWM block is disabled. This is meant to be used if inverted polarity of the
+ PWM signal is required. See "Inverted PWM output" section bellow.
+
Example:
pwm1: pwm@53fb4000 {
@@ -25,3 +31,41 @@ pwm1: pwm@53fb4000 {
clock-names = "ipg", "per";
interrupts = <61>;
};
+
+Inverted PWM output
+-------------------
+
+The i.MX SoC has such limitation that whenever a pad is configured as a PWM
+output, the output level is always zero volts when the PWM block is disabled.
+The zero output level is actively driven by the output stage of the PWM block
+and can not be overridden by pull-up. It also does not matter what PWM polarity
+a PWM client (e.g. backlight) requested.
+
+To gain control of the PWM output level in disabled state two pinctrl states
+can be used. The "default" state and the "pwm" state. In the default state the
+PWM output is configured as a GPIO with pull-up. In the "pwm" state the output
+is configured as a PWM output. This setup assures that the PWM output is at
+the required level that corresponds to duty cycle = 0 when PWM is disabled.
+E.g. at boot.
+
+Example:
+
+&pwm1 {
+ pinctrl-names = "default", "pwm";
+ pinctrl-0 = <&pinctrl_backlight_gpio>;
+ pinctrl-1 = <&pinctrl_backlight_pwm>;
+}
+
+pinctrl_backlight_gpio: pwm1grp-gpio {
+ fsl,pins = <
+ /* GPIO with 22kOhm pull-up */
+ MX6QDL_PAD_GPIO_9__GPIO1_IO09 0xF008
+ >;
+};
+
+pinctrl_backlight_pwm: pwm1grp-pwm {
+ fsl,pins = <
+ /* PWM output */
+ MX6QDL_PAD_GPIO_9__PWM1_OUT 0x8
+ >;
+};
--
2.1.4
next prev parent reply other threads:[~2018-08-21 14:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 14:38 [RFC PATCH 0/2] pwm: imx: Configure output to GPIO in disabled state Michal Vokáč
2018-08-21 14:38 ` Michal Vokáč [this message]
2018-08-22 6:14 ` [RFC PATCH 1/2] dt-bindings: pwm: imx: Allow switching PWM output between PWM and GPIO Lothar Waßmann
2018-08-22 7:01 ` Michal Vokáč
2018-08-22 11:17 ` Lothar Waßmann
2018-08-22 13:20 ` Michal Vokáč
2018-08-22 14:10 ` Lothar Waßmann
2018-08-23 9:13 ` Michal Vokáč
2018-08-23 11:18 ` Lothar Waßmann
2018-08-23 12:38 ` Michal Vokáč
2018-08-23 10:40 ` Lukasz Majewski
2018-08-23 11:19 ` Lothar Waßmann
2018-08-23 11:21 ` Michal Vokáč
2018-08-23 12:36 ` Lukasz Majewski
2018-10-09 11:03 ` Vokáč Michal
2018-08-31 12:18 ` Rob Herring
2018-08-31 12:45 ` Lothar Waßmann
2018-08-31 13:17 ` Michal Vokáč
2018-08-31 13:30 ` Lothar Waßmann
2018-10-09 10:30 ` Vokáč Michal
2018-08-21 14:38 ` [RFC PATCH 2/2] pmw: imx: Configure output to GPIO in disabled state Michal Vokáč
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534862333-27950-2-git-send-email-michal.vokac@ysoft.com \
--to=michal.vokac@ysoft.com \
--cc=LW@karo-electronics.de \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=l.majewski@majess.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).