From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Cercueil Subject: Re: [PATCH v2 1/6] dt-bindings: Remove unused compatible strings Date: Mon, 08 Jul 2019 23:18:19 -0400 Message-ID: <1562642299.1834.0@crapouillou.net> References: <20190607154410.10633-1-paul@crapouillou.net> <20190607154410.10633-2-paul@crapouillou.net> <20190709020425.GA7984@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190709020425.GA7984@bogus> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Thierry Reding , Mark Rutland , od@zcrc.me, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-pwm@vger.kernel.org Le lun. 8 juil. 2019 =E0 22:04, Rob Herring a =E9crit : > On Fri, Jun 07, 2019 at 05:44:05PM +0200, Paul Cercueil wrote: >> Right now none of the Ingenic-based boards probe this driver from >> devicetree. This driver defined three compatible strings for the=20 >> exact >> same behaviour. Before these strings are used, we can remove two of >> them. >>=20 >> Signed-off-by: Paul Cercueil >> --- >>=20 >> Notes: >> v2: Rebase on v5.2-rc3 >>=20 >> Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt | 5=20 >> +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >>=20 >> diff --git=20 >> a/Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt=20 >> b/Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt >> index 7d9d3f90641b..493bec80d59b 100644 >> --- a/Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt >> +++ b/Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt >> @@ -2,10 +2,7 @@ Ingenic JZ47xx PWM Controller >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D >>=20 >> Required properties: >> -- compatible: One of: >> - * "ingenic,jz4740-pwm" >> - * "ingenic,jz4770-pwm" >> - * "ingenic,jz4780-pwm" >> +- compatible: Should be "ingenic,jz4740-pwm" >=20 > Are you sure all 3 chips are exactly the same features and bugs? The hardware on these chips have tiny differences, but the current driver code works on all the SoCs. > The correct thing to do here generally is the 4770 and 4780 would also > have ingenic,jz4740-pwm as a fallback compatible. Then the driver can > match on that until you find some difference and can use the more > specific compatible. Why not just update the devicetree with the new compatible string when a difference is found? >> - #pwm-cells: Should be 3. See pwm.txt in this directory for a=20 >> description >> of the cells format. >> - clocks : phandle to the external clock. >> -- >> 2.21.0.593.g511ec345e18 >>=20 =