From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Cc: geert@glider.be, horms@verge.net.au, linux-pwm@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, magnus.damm@gmail.com
Subject: Re: [PATCH v2 4/8] arm64: dts: r8a7796: salvator-x: Add panel backlight support
Date: Thu, 27 Apr 2017 17:43:56 +0300 [thread overview]
Message-ID: <1600524.FrhoU262MZ@avalon> (raw)
In-Reply-To: <1493303863-23719-5-git-send-email-ulrich.hecht+renesas@gmail.com>
Hi Ulrich,
Thank you for the patch.
On Thursday 27 Apr 2017 16:37:39 Ulrich Hecht wrote:
> The panel backlight is controlled through a GPIO and a PWM channel.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 22 ++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts index 14d9e51..abda84c
> 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> @@ -133,6 +133,11 @@
> function = "i2c2";
> };
>
> + pwm1_pins: pwm {
> + groups = "pwm1_a";
> + function = "pwm1";
> + };
> +
> sdhi0_pins: sd0 {
> groups = "sdhi0_data4", "sdhi0_ctrl";
> function = "sdhi0";
> @@ -183,6 +188,16 @@
> interrupt-parent = <&gpio2>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&pwm1 0 50000>;
> +
> + brightness-levels = <256 128 64 16 8 4 0>;
> + default-brightness-level = <6>;
> +
> + enable-gpios = <&gpio6 7 GPIO_ACTIVE_HIGH>;
> + };
> };
>
> &extal_clk {
> @@ -235,6 +250,13 @@
> status = "okay";
> };
>
> +&pwm1 {
> + pinctrl-0 = <&pwm1_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +};
> +
> &scif1 {
> pinctrl-0 = <&scif1_pins>;
> pinctrl-names = "default";
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-04-27 14:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 14:37 [PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement Ulrich Hecht
2017-04-27 14:37 ` [PATCH v2 1/8] pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions Ulrich Hecht
2017-04-27 14:37 ` [PATCH v2 2/8] clk: renesas: r8a7796: add PWM clock Ulrich Hecht
2017-04-27 14:37 ` [PATCH v2 3/8] arm64: dts: r8a7796: Add PWM device nodes Ulrich Hecht
2017-04-27 14:37 ` [PATCH v2 4/8] arm64: dts: r8a7796: salvator-x: Add panel backlight support Ulrich Hecht
2017-04-27 14:43 ` Laurent Pinchart [this message]
2017-05-13 18:56 ` Laurent Pinchart
2017-05-15 5:48 ` Simon Horman
2017-05-15 6:50 ` Laurent Pinchart
2017-05-15 6:59 ` Simon Horman
2017-09-05 15:08 ` Geert Uytterhoeven
2017-04-27 14:37 ` [PATCH v2 5/8] arm64: dts: r8a7796-salvator-x: Add PWM device support Ulrich Hecht
2017-04-27 14:37 ` [PATCH v2 6/8] arm64: dts: r8a7795: salvator-x: Add panel backlight support Ulrich Hecht
2017-04-27 14:42 ` Laurent Pinchart
2017-04-27 14:43 ` Laurent Pinchart
2017-04-28 5:23 ` Simon Horman
2017-04-27 14:37 ` [PATCH v2 7/8] arm64: dts: r8a7795-salvator-x: Enable PWM2 Ulrich Hecht
2017-04-27 14:40 ` Laurent Pinchart
2017-08-30 8:06 ` Simon Horman
2017-08-30 8:08 ` Simon Horman
2017-04-27 14:37 ` [PATCH v2 8/8] dt-bindings: pwm: Add R-Car M3-W device tree bindings Ulrich Hecht
2017-04-27 14:50 ` Geert Uytterhoeven
2017-04-28 5:24 ` Simon Horman
2017-04-28 7:29 ` [PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement Simon Horman
2017-05-12 9:16 ` Simon Horman
2017-05-12 10:00 ` Laurent Pinchart
2017-05-12 10:36 ` Ulrich Hecht
2017-05-12 11:03 ` Laurent Pinchart
2017-05-15 5:42 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600524.FrhoU262MZ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert@glider.be \
--cc=horms@verge.net.au \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).