From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6FD9C04FDF for ; Thu, 10 Aug 2023 16:21:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236721AbjHJQVm (ORCPT ); Thu, 10 Aug 2023 12:21:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232940AbjHJQVl (ORCPT ); Thu, 10 Aug 2023 12:21:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6281F26A0; Thu, 10 Aug 2023 09:21:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2608662F0; Thu, 10 Aug 2023 16:21:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BE51C433C7; Thu, 10 Aug 2023 16:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691684495; bh=hCwAGNIRbmhd9GFgLU8q0nWUYmzdIjXNkRYpjhTQKhc=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=cd/j3BW98vgcZo/RJxhBP6SFvlhvk23q4ABBH79QyLK2gpggMzpq5RdUqrg8pofq8 57t24mZY7DT5fy88eJCl9TcJUO3o+CLPuRac5myfWkZ0rguItvIz2QGdCzjIDJApZ0 XBoaLFzgl1ZJZkZ+QqF1//ekMRVs4OcRBzsQGNk7abLZSl2cFh57N2T6TVNOOQ55BM DeVcznijWwEZ7nPBFEzRYmp7b+8+UnMO2NPNTZaSby6FM6JLpRgNx15zH322qKJJ4a JdTTkrhdHVCGMhBFMtJeUfPRQTN8pVqKwQaqqMOC0iuRiSYrN+dpBhRuAuL6DC81wL 8axN1JLJ3Wu+w== Received: (nullmailer pid 480251 invoked by uid 1000); Thu, 10 Aug 2023 16:21:30 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Rob Herring To: Aleksandr Shubin Cc: Jernej Skrabec , Samuel Holland , Philipp Zabel , Heiko Stuebner , Palmer Dabbelt , Conor Dooley , Rob Herring , linux-riscv@lists.infradead.org, Thierry Reding , linux-pwm@vger.kernel.org, Chen-Yu Tsai , devicetree@vger.kernel.org, Paul Walmsley , linux-arm-kernel@lists.infradead.org, Albert Ou , linux-sunxi@lists.linux.dev, Krzysztof Kozlowski , Cristian Ciocaltea , linux-kernel@vger.kernel.org, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= In-Reply-To: <20230810145443.1053387-2-privatesub2@gmail.com> References: <20230810145443.1053387-1-privatesub2@gmail.com> <20230810145443.1053387-2-privatesub2@gmail.com> Message-Id: <169168449014.480213.11243622755862466051.robh@kernel.org> Subject: Re: [PATCH v4 1/3] dt-bindings: pwm: Add binding for Allwinner D1/T113-S3/R329 PWM controller Date: Thu, 10 Aug 2023 10:21:30 -0600 Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On Thu, 10 Aug 2023 17:54:26 +0300, Aleksandr Shubin wrote: > Allwinner's D1, T113-S3 and R329 SoCs have a new pwm > controller witch is different from the previous pwm-sun4i. > > The D1 and T113 are identical in terms of peripherals, > they differ only in the architecture of the CPU core, and > even share the majority of their DT. Because of that, > using the same compatible makes sense. > The R329 is a different SoC though, and should have > a different compatible string added, especially as there > is a difference in the number of channels. > > D1 and T113s SoCs have one PWM controller with 8 channels. > R329 SoC has two PWM controllers in both power domains, one of > them has 9 channels (CPUX one) and the other has 6 (CPUS one). > > Add a device tree binding for them. > > Signed-off-by: Aleksandr Shubin > --- > .../bindings/pwm/allwinner,sun20i-pwm.yaml | 86 +++++++++++++++++++ > 1 file changed, 86 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/allwinner,sun20i-pwm.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230810145443.1053387-2-privatesub2@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.