From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Thierry Reding <thierry.reding@gmail.com>,
paul@crapouillou.net, u.kleine-koenig@pengutronix.de,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pwm: Add missing '\n' in log messages
Date: Tue, 14 Apr 2020 12:09:49 -0700 [thread overview]
Message-ID: <19df87f5d093a6c2721316811aca1c90d287bf1d.camel@perches.com> (raw)
In-Reply-To: <20200414184925.GA12862@kadam>
On Tue, 2020-04-14 at 21:49 +0300, Dan Carpenter wrote:
> Huh...
>
> If you look at dev_vprintk_emit(). It looks like if
> create_syslog_header() returns a string then vprintk_store() will add
> a newline.
>
> I guess that means that dev_printk() can't be used to pr_cont(). And
> probably that's deliberate because using pr_cont() after boot is racy
> anyway.
Perhaps that's true, it didn't used to be.
There are couple dozen or so KERN_CONT uses after a dev_<level>
without a newline, so those _might_ be broken, but I don't thinks so.
$ git grep -P -A10 '\bdev_\w+\s*\(' | \
grep -P -B10 "KERN_CONT|pr_cont"
next prev parent reply other threads:[~2020-04-14 19:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 15:35 [PATCH] pwm: Add missing '\n' in log messages Christophe JAILLET
2020-04-11 16:37 ` Uwe Kleine-König
2020-04-14 13:58 ` Thierry Reding
2020-04-14 18:30 ` Christophe JAILLET
2020-04-14 18:49 ` Dan Carpenter
2020-04-14 19:09 ` Joe Perches [this message]
2020-04-14 19:04 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19df87f5d093a6c2721316811aca1c90d287bf1d.camel@perches.com \
--to=joe@perches.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox