From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 498451429E for ; Wed, 17 Jan 2024 10:21:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705486872; cv=none; b=BvdSsf9adrBePsJw+Qe9tzZ3/cdsv6uYGBIW0dNq3L4BIi8l7OGzOJZFQulvx4JxSQAkJCuYvWjEQqPq/NAMFtsXrgjcmGahSLG15+VFDnX2sClrN2dPdlhgtbVP5ZG7VT71bqCnrtAmYetefPAZ6J/7laNue0Y96eEWs4cnij0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705486872; c=relaxed/simple; bh=fA8fOIDmpDf6O1sgGqy94Z1yqgjC5fUGvhAPgezy1N0=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:Received: References:User-agent:From:To:Cc:Subject:Date:In-reply-to: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; b=g3jrIeaq0lMuMeYzO/AL85JXgDdHTbpOjfg+fj1Q8eJBh8sp1mAH1WjgKYYatCzKnuCwXHC2GZ1FbMeUx7ldnvRRID5kwi1DSJtCbHF/doLW/kYBv2PbECIP40E/pbDUdodqihCBL2GAUnoNm78I/rJ+pfAQOmkhDUHKYx2rZBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=owr485wz; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="owr485wz" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-40e7065b692so35883085e9.3 for ; Wed, 17 Jan 2024 02:21:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1705486867; x=1706091667; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=5mSVG7D4F/4/rMlg7YZmDmtDRH4U8gyyZuRonzPy+H4=; b=owr485wzoOgCgR7SlEzjfEy+Cl+cdj/22FfX4CcxSFSHtx6Dt5iAJWgkJ0q5VZ9vgr fs7rgRtaCBVN6c42pRwbYb8evWjvVvU3jLcYijFTgLSqyD7vsjSQv1US48gLqli2zy7o sl2nLgXJh+kTaivTGzjvSvkHGKPOSd2xcUPuLxd75bGf2zurL7wwL9l11ceCVYHhu68w 705aJgy0G0wQ/dztCtwdFlPA35w1xzpdIey9R5kLsb3qL5K6VgQdN+dVs0IPnEuIsD/p 4yALn3JWFMKsLSs6wqC8SE0pSMLj/O3eTYZy9Pb4C7KFFkzApvdDILDlbuOPWRNQDlGI oW1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705486867; x=1706091667; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5mSVG7D4F/4/rMlg7YZmDmtDRH4U8gyyZuRonzPy+H4=; b=OeS3yG/V4yFF1b1NeM4jXucdQmu9rc6exWtWrVPt/U301loJEGOdbOAfNwf0bwdcmD hom3gWWly7WTS3UXZDOkLKLEhIzg9f7rpKkLECQgv7WUM3kK1ztOUmEWYgrdpUEt7aXd BCtgB9ubC/FjPKYh51tvPKJYY+ZR3BZ5JiLHEdGxvKt9rvrcC7pHLCklg80QLmbB5quO p5WZNjZoushaFWOx2YCEqp+tiOtRwwdmlIwyOhqRbXj/21scl4e3Z9+1R0ncGd6DWMr1 ye/Fn4wu8rxkJFvMz+iwj3UsAyIGkNUwuFtOwR4V2g5vX6Bjd31gzssV3lTO1zWNR2Is oRJQ== X-Gm-Message-State: AOJu0YzGoQ4IALhrz3o1DZaY0TDOwMM7K3fiYSfu6IIoLANpBT9u1n0R cQ2njbg9lEj/l7gE07K/NKiMTZ3iJ65nJA== X-Google-Smtp-Source: AGHT+IHkPtaUfaJlpb5rgGajtKU+P5rzVz0YPS17UdzuHDV8aXYHDcinmlVZjk1+b215qJd7ggkx8A== X-Received: by 2002:a05:600c:22cc:b0:40e:3dcd:2e24 with SMTP id 12-20020a05600c22cc00b0040e3dcd2e24mr4695637wmg.180.1705486867325; Wed, 17 Jan 2024 02:21:07 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:c1f6:14ce:b96f:2df5]) by smtp.gmail.com with ESMTPSA id v13-20020a05600c444d00b0040e526bd5fdsm1894578wmn.1.2024.01.17.02.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 02:21:06 -0800 (PST) References: <20231222111658.832167-1-jbrunet@baylibre.com> <20231222111658.832167-3-jbrunet@baylibre.com> <4rdb2be2bfzak3s4uaizthcdcdwdrxnx4kr2sgn527hvsie3pb@gfqciim7yryz> User-agent: mu4e 1.10.8; emacs 29.1 From: Jerome Brunet To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Jerome Brunet , Thierry Reding , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-pwm@vger.kernel.org, JunYi Zhao Subject: Re: [PATCH v4 2/6] dt-bindings: pwm: amlogic: add new compatible for meson8 pwm type Date: Wed, 17 Jan 2024 11:16:31 +0100 In-reply-to: <4rdb2be2bfzak3s4uaizthcdcdwdrxnx4kr2sgn527hvsie3pb@gfqciim7yryz> Message-ID: <1jfrywxnu5.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed 17 Jan 2024 at 10:58, Uwe Kleine-K=C3=B6nig wrote: > [[PGP Signed Part:Undecided]] > Hello, > > On Fri, Dec 22, 2023 at 12:16:50PM +0100, Jerome Brunet wrote: >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Do= cumentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> index a1d382aacb82..eece390114a3 100644 >> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> @@ -21,23 +21,35 @@ properties: >> - amlogic,meson-g12a-ee-pwm >> - amlogic,meson-g12a-ao-pwm-ab >> - amlogic,meson-g12a-ao-pwm-cd >> - - amlogic,meson-s4-pwm >> + deprecated: true >> - items: >> - const: amlogic,meson-gx-pwm >> - const: amlogic,meson-gxbb-pwm >> + deprecated: true >> - items: >> - const: amlogic,meson-gx-ao-pwm >> - const: amlogic,meson-gxbb-ao-pwm >> + deprecated: true >> - items: >> - const: amlogic,meson8-pwm >> - const: amlogic,meson8b-pwm >> + deprecated: true > > I think deprecating the old binding and adding a new compatible should > be done in two commits. Hi Uwe, There was the same comment on v3 and Krzysztof said it should be done like this: https://lore.kernel.org/linux-pwm/e127dcef-3149-443a-9a8c-d24ef4054f09@lina= ro.org I tend to agree with Krzysztof on this but, as I previously said, I don't really mind one way or the other. Just have to pick one. > >> + - const: amlogic,meson8-pwm-v2 >> + - items: >> + - enum: >> + - amlogic,meson8b-pwm-v2 >> + - amlogic,meson-gxbb-pwm-v2 >> + - amlogic,meson-axg-pwm-v2 >> + - amlogic,meson-g12-pwm-v2 >> + - const: amlogic,meson8-pwm-v2 >> + - const: amlogic,meson-s4-pwm > > Best regards > Uwe --=20 Jerome