From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guru Das Srinagesh Subject: [PATCH v10 11/12] clk: pwm: Assign u64 divisor to unsigned int before use Date: Thu, 19 Mar 2020 13:50:14 -0700 Message-ID: <2009030fe415c02cc92f0189d3e79de34982536c.1584650604.git.gurus@codeaurora.org> References: Return-path: Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:27920 "EHLO alexa-out-sd-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727297AbgCSUuW (ORCPT ); Thu, 19 Mar 2020 16:50:22 -0400 In-Reply-To: In-Reply-To: References: Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: linux-pwm@vger.kernel.org Cc: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Subbaraman Narayanamurthy , linux-kernel@vger.kernel.org, Guru Das Srinagesh , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, David Laight Since the PWM framework is switching struct pwm_args.period's datatype to u64, prepare for this transition by assigning the 64-bit divisor to an unsigned int variable to use as the divisor. This is being done because the divisor is a 32-bit constant and the quotient will be zero if the divisor exceeds 2^32. Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-clk@vger.kernel.org Cc: David Laight Reported-by: kbuild test robot Signed-off-by: Guru Das Srinagesh --- drivers/clk/clk-pwm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-pwm.c b/drivers/clk/clk-pwm.c index 87fe0b0e..c0b5da3 100644 --- a/drivers/clk/clk-pwm.c +++ b/drivers/clk/clk-pwm.c @@ -72,6 +72,7 @@ static int clk_pwm_probe(struct platform_device *pdev) struct pwm_device *pwm; struct pwm_args pargs; const char *clk_name; + unsigned int period; int ret; clk_pwm = devm_kzalloc(&pdev->dev, sizeof(*clk_pwm), GFP_KERNEL); @@ -88,8 +89,9 @@ static int clk_pwm_probe(struct platform_device *pdev) return -EINVAL; } + period = pargs.period; if (of_property_read_u32(node, "clock-frequency", &clk_pwm->fixed_rate)) - clk_pwm->fixed_rate = NSEC_PER_SEC / pargs.period; + clk_pwm->fixed_rate = NSEC_PER_SEC / period; if (pargs.period != NSEC_PER_SEC / clk_pwm->fixed_rate && pargs.period != DIV_ROUND_UP(NSEC_PER_SEC, clk_pwm->fixed_rate)) { -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project