From: Thierry Reding <thierry.reding@gmail.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org,
poeschel@lemonage.de, Ryan Mallon <rmallon@gmail.com>,
rob@landley.net
Subject: Re: [PATCH v5] pwm: add sysfs interface
Date: Fri, 21 Jun 2013 11:32:08 +0200 [thread overview]
Message-ID: <20130621093207.GC31464@manwe> (raw)
In-Reply-To: <201306111039.00344.hartleys@visionengravers.com>
[-- Attachment #1: Type: text/plain, Size: 2009 bytes --]
On Tue, Jun 11, 2013 at 10:38:59AM -0700, H Hartley Sweeten wrote:
> Add a simple sysfs interface to the generic PWM framework.
>
> /sys/class/pwm/
> `-- pwmchipN/ for each PWM chip
> |-- export (w/o) ask the kernel to export a PWM channel
> |-- npwm (r/o) number of PWM channels in this PWM chip
> |-- pwmX/ for each exported PWM channel
> | |-- duty_cycle (r/w) duty cycle (in nanoseconds)
> | |-- enable (r/w) enable/disable PWM
> | |-- period (r/w) period (in nanoseconds)
> | `-- polarity (r/w) polarity of PWM (normal/inversed)
> `-- unexport (w/o) return a PWM channel to the kernel
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Lars Poeschel <poeschel@lemonage.de>
> Cc: Ryan Mallon <rmallon@gmail.com>
> Cc: Rob Landley <rob@landley.net>
> ---
> v5: * rename the 'duty' attribute to 'duty_cycle'
> * make the Kconfig option hidden and enabled when CONFIG_SYSFS
> is enabled
> * use sysfs_streq() in pwm_polarity_store()
> v4: * address a number of issues pointed out by Thierry Reding
> - fix some typos and wording issues in the Documentation
> - rename the new source file to sysfs.c
> - rename some of the variables in sysfs.c to clarify them
> - fix the period store so it does not change the duty cycle
> - change the polarity attribute to use a string representation
> - add a warning message is the pwmchip_sysfs_export() fails
> v3: * fix an issue with the export/unexport of the PWM chip
> v2: * add API documentation and update Documentation/pwm.txt
> * fix some issues pointed out by Ryan Mallon
> * add the pwm attributes to dev.groups so they are created
> when the device is registered for the exported PWM
> v1: * Based on previous work by Lars Poecshel
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-06-21 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 17:38 [PATCH v5] pwm: add sysfs interface H Hartley Sweeten
2013-06-21 9:32 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130621093207.GC31464@manwe \
--to=thierry.reding@gmail.com \
--cc=hartleys@visionengravers.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=poeschel@lemonage.de \
--cc=rmallon@gmail.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).