On Tue, Jun 25, 2013 at 10:59:49AM +0200, Laurent Pinchart wrote: > Hi Wei, > > Thank you for the patch. > > On Tuesday 25 June 2013 10:09:57 Wei Yongjun wrote: > > From: Wei Yongjun > > > > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > > and never returns NULL. The NULL test in the return value check should > > be replaced with IS_ERR(). > > > > Signed-off-by: Wei Yongjun > > With the change noted below, > > Acked-by: Laurent Pinchart > > Thierry, do you need a v2, or can you fix the patch while applying ? No that's fine, I'll fix it up when applying. I should've noticed in the first place anyway since I wrote devm_ioremap_resource() specifically so that it never returns NULL and the error message wasn't required. =\ Thanks, Thierry