* [PATCH] pwm: pwm-tiehrpwm: add missing __iomem annotation
@ 2013-08-02 6:22 Jingoo Han
2013-08-14 9:46 ` Thierry Reding
2013-08-14 10:48 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-08-02 6:22 UTC (permalink / raw)
To: 'Thierry Reding'; +Cc: linux-pwm, 'Jingoo Han'
Fix the following sparse warnings:
drivers/pwm/pwm-tiehrpwm.c:144:16: warning: incorrect type in argument 1 (different address spaces)
drivers/pwm/pwm-tiehrpwm.c:144:16: expected void const volatile [noderef] <asn:2>*addr
drivers/pwm/pwm-tiehrpwm.c:144:16: got void *
drivers/pwm/pwm-tiehrpwm.c:149:9: warning: incorrect type in argument 2 (different address spaces)
drivers/pwm/pwm-tiehrpwm.c:149:9: expected void volatile [noderef] <asn:2>*addr
drivers/pwm/pwm-tiehrpwm.c:149:9: got void *
drivers/pwm/pwm-tiehrpwm.c:157:18: warning: incorrect type in argument 1 (different address spaces)
drivers/pwm/pwm-tiehrpwm.c:157:18: expected void const volatile [noderef] <asn:2>*addr
drivers/pwm/pwm-tiehrpwm.c:157:18: got void *
drivers/pwm/pwm-tiehrpwm.c:160:9: warning: incorrect type in argument 2 (different address spaces)
drivers/pwm/pwm-tiehrpwm.c:160:9: expected void volatile [noderef] <asn:2>*addr
drivers/pwm/pwm-tiehrpwm.c:160:9: got void *
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pwm/pwm-tiehrpwm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
index aa4c558..084f552 100644
--- a/drivers/pwm/pwm-tiehrpwm.c
+++ b/drivers/pwm/pwm-tiehrpwm.c
@@ -139,17 +139,17 @@ static inline struct ehrpwm_pwm_chip *to_ehrpwm_pwm_chip(struct pwm_chip *chip)
return container_of(chip, struct ehrpwm_pwm_chip, chip);
}
-static u16 ehrpwm_read(void *base, int offset)
+static u16 ehrpwm_read(void __iomem *base, int offset)
{
return readw(base + offset);
}
-static void ehrpwm_write(void *base, int offset, unsigned int val)
+static void ehrpwm_write(void __iomem *base, int offset, unsigned int val)
{
writew(val & 0xFFFF, base + offset);
}
-static void ehrpwm_modify(void *base, int offset,
+static void ehrpwm_modify(void __iomem *base, int offset,
unsigned short mask, unsigned short val)
{
unsigned short regval;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: pwm-tiehrpwm: add missing __iomem annotation
2013-08-02 6:22 [PATCH] pwm: pwm-tiehrpwm: add missing __iomem annotation Jingoo Han
@ 2013-08-14 9:46 ` Thierry Reding
2013-08-14 10:48 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2013-08-14 9:46 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Thierry Reding', linux-pwm
[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]
On Fri, Aug 02, 2013 at 03:22:03PM +0900, Jingoo Han wrote:
> Fix the following sparse warnings:
>
> drivers/pwm/pwm-tiehrpwm.c:144:16: warning: incorrect type in argument 1 (different address spaces)
> drivers/pwm/pwm-tiehrpwm.c:144:16: expected void const volatile [noderef] <asn:2>*addr
> drivers/pwm/pwm-tiehrpwm.c:144:16: got void *
> drivers/pwm/pwm-tiehrpwm.c:149:9: warning: incorrect type in argument 2 (different address spaces)
> drivers/pwm/pwm-tiehrpwm.c:149:9: expected void volatile [noderef] <asn:2>*addr
> drivers/pwm/pwm-tiehrpwm.c:149:9: got void *
> drivers/pwm/pwm-tiehrpwm.c:157:18: warning: incorrect type in argument 1 (different address spaces)
> drivers/pwm/pwm-tiehrpwm.c:157:18: expected void const volatile [noderef] <asn:2>*addr
> drivers/pwm/pwm-tiehrpwm.c:157:18: got void *
> drivers/pwm/pwm-tiehrpwm.c:160:9: warning: incorrect type in argument 2 (different address spaces)
> drivers/pwm/pwm-tiehrpwm.c:160:9: expected void volatile [noderef] <asn:2>*addr
> drivers/pwm/pwm-tiehrpwm.c:160:9: got void *
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pwm/pwm-tiehrpwm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: pwm-tiehrpwm: add missing __iomem annotation
2013-08-02 6:22 [PATCH] pwm: pwm-tiehrpwm: add missing __iomem annotation Jingoo Han
2013-08-14 9:46 ` Thierry Reding
@ 2013-08-14 10:48 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2013-08-14 10:48 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Thierry Reding', linux-pwm
[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]
On Fri, Aug 02, 2013 at 03:22:03PM +0900, Jingoo Han wrote:
> Fix the following sparse warnings:
>
> drivers/pwm/pwm-tiehrpwm.c:144:16: warning: incorrect type in argument 1 (different address spaces)
> drivers/pwm/pwm-tiehrpwm.c:144:16: expected void const volatile [noderef] <asn:2>*addr
> drivers/pwm/pwm-tiehrpwm.c:144:16: got void *
> drivers/pwm/pwm-tiehrpwm.c:149:9: warning: incorrect type in argument 2 (different address spaces)
> drivers/pwm/pwm-tiehrpwm.c:149:9: expected void volatile [noderef] <asn:2>*addr
> drivers/pwm/pwm-tiehrpwm.c:149:9: got void *
> drivers/pwm/pwm-tiehrpwm.c:157:18: warning: incorrect type in argument 1 (different address spaces)
> drivers/pwm/pwm-tiehrpwm.c:157:18: expected void const volatile [noderef] <asn:2>*addr
> drivers/pwm/pwm-tiehrpwm.c:157:18: got void *
> drivers/pwm/pwm-tiehrpwm.c:160:9: warning: incorrect type in argument 2 (different address spaces)
> drivers/pwm/pwm-tiehrpwm.c:160:9: expected void volatile [noderef] <asn:2>*addr
> drivers/pwm/pwm-tiehrpwm.c:160:9: got void *
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pwm/pwm-tiehrpwm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-14 10:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-02 6:22 [PATCH] pwm: pwm-tiehrpwm: add missing __iomem annotation Jingoo Han
2013-08-14 9:46 ` Thierry Reding
2013-08-14 10:48 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).