From: Lee Jones <lee.jones@linaro.org>
To: Milo Kim <milo.kim@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pwm@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH v3 1/4] mfd: add LP3943 MFD driver
Date: Thu, 12 Sep 2013 16:40:00 +0100 [thread overview]
Message-ID: <20130912154000.GP11227@lee--X1> (raw)
In-Reply-To: <1378949524-6143-1-git-send-email-milo.kim@ti.com>
On Thu, 12 Sep 2013, Milo Kim wrote:
> LP3943 has 16 output pins which can be used as GPIO expander and PWM generator.
>
> * Regmap I2C interface for R/W LP3943 registers
>
> * Atomic operations for output pin assignment
> The driver should check whether requested pin is available or not.
> If the pin is already used, pin request returns as a failure.
> A driver data, 'pin_used' is checked when gpio_request() and
> pwm_request() are called. If the pin is available, then pin_used is set.
> And it is cleared when gpio_free() and pwm_free().
>
> * Device tree support
> Compatible strings for GPIO and PWM driver.
> LP3943 platform data is PWM related, so parsing the device tree is
> implemented in the PWM driver.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Milo Kim <milo.kim@ti.com>
> ---
> * Patch v3
> Now, output pin number is exactly matched with enum value of '
> lp3943_pwm_output'.
> Use dev_get_platdata() helper function in probe().
> Use module_i2c_driver() for initcall.
>
> * Patch v2
> Handle atomic operations for output pin assignment.
>
> drivers/mfd/Kconfig | 11 ++++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/lp3943.c | 148 ++++++++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/lp3943.h | 114 ++++++++++++++++++++++++++++++++++
> 4 files changed, 274 insertions(+)
> create mode 100644 drivers/mfd/lp3943.c
> create mode 100644 include/linux/mfd/lp3943.h
Code looks good to me. For the MFD parts:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2013-09-12 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 1:32 [PATCH v3 1/4] mfd: add LP3943 MFD driver Milo Kim
2013-09-12 15:40 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912154000.GP11227@lee--X1 \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=sameo@linux.intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).