From: Thierry Reding <thierry.reding@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>,
Rob Landley <rob@landley.net>,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: sysfs: Convert to use ATTRIBUTE_GROUPS macro
Date: Wed, 4 Dec 2013 11:05:30 +0100 [thread overview]
Message-ID: <20131204100529.GV19943@ulmo.nvidia.com> (raw)
In-Reply-To: <1386139970.9997.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
On Wed, Dec 04, 2013 at 02:52:50PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pwm/sysfs.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
Looks good. Can you please add a commit message? If nothing else it
could say what the advantages are of using the macro, even if that may
be somewhat obvious.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-12-04 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 6:52 [PATCH] pwm: sysfs: Convert to use ATTRIBUTE_GROUPS macro Axel Lin
2013-12-04 10:05 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204100529.GV19943@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=axel.lin@ingics.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-pwm@vger.kernel.org \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).