* [PATCH 1/3] pwm: core: use seq_puts() instead of seq_printf()
@ 2013-12-19 4:31 Jingoo Han
2013-12-19 4:32 ` [PATCH 2/3] pwm: pwm-ep93xx: split module author names Jingoo Han
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jingoo Han @ 2013-12-19 4:31 UTC (permalink / raw)
To: 'Thierry Reding'; +Cc: linux-pwm, 'Jingoo Han'
For a constant format without additional arguments, use seq_puts()
instead of seq_printf(). Also, the following checkpatch warning is
fixed.
WARNING: Prefer seq_puts to seq_printf
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pwm/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 2ca9504..a804713 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -808,12 +808,12 @@ static void pwm_dbg_show(struct pwm_chip *chip, struct seq_file *s)
seq_printf(s, " pwm-%-3d (%-20.20s):", i, pwm->label);
if (test_bit(PWMF_REQUESTED, &pwm->flags))
- seq_printf(s, " requested");
+ seq_puts(s, " requested");
if (test_bit(PWMF_ENABLED, &pwm->flags))
- seq_printf(s, " enabled");
+ seq_puts(s, " enabled");
- seq_printf(s, "\n");
+ seq_puts(s, "\n");
}
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/3] pwm: pwm-ep93xx: split module author names
2013-12-19 4:31 [PATCH 1/3] pwm: core: use seq_puts() instead of seq_printf() Jingoo Han
@ 2013-12-19 4:32 ` Jingoo Han
2013-12-19 4:34 ` [PATCH 3/3] pwm: pxa: remove unnecessary space before tabs Jingoo Han
2013-12-20 9:58 ` [PATCH 1/3] pwm: core: use seq_puts() instead of seq_printf() Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-12-19 4:32 UTC (permalink / raw)
To: 'Thierry Reding'
Cc: linux-pwm, 'Jingoo Han', 'H Hartley Sweeten'
Split module author names in order to fix the following
checkpatch warning.
WARNING: quoted string split across lines
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pwm/pwm-ep93xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-ep93xx.c
index 33aa446..e593e9c 100644
--- a/drivers/pwm/pwm-ep93xx.c
+++ b/drivers/pwm/pwm-ep93xx.c
@@ -224,7 +224,7 @@ static struct platform_driver ep93xx_pwm_driver = {
module_platform_driver(ep93xx_pwm_driver);
MODULE_DESCRIPTION("Cirrus Logic EP93xx PWM driver");
-MODULE_AUTHOR("Matthieu Crapet <mcrapet@gmail.com>, "
- "H Hartley Sweeten <hsweeten@visionengravers.com>");
+MODULE_AUTHOR("Matthieu Crapet <mcrapet@gmail.com>");
+MODULE_AUTHOR("H Hartley Sweeten <hsweeten@visionengravers.com>");
MODULE_ALIAS("platform:ep93xx-pwm");
MODULE_LICENSE("GPL");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 3/3] pwm: pxa: remove unnecessary space before tabs
2013-12-19 4:31 [PATCH 1/3] pwm: core: use seq_puts() instead of seq_printf() Jingoo Han
2013-12-19 4:32 ` [PATCH 2/3] pwm: pwm-ep93xx: split module author names Jingoo Han
@ 2013-12-19 4:34 ` Jingoo Han
2013-12-20 9:58 ` [PATCH 1/3] pwm: core: use seq_puts() instead of seq_printf() Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-12-19 4:34 UTC (permalink / raw)
To: 'Thierry Reding'
Cc: linux-pwm, 'Jingoo Han', 'Eric Miao'
Remove unnecessary space before tabs in order to fix the following
checkpatch warning.
WARNING: please, no space before tabs
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/pwm/pwm-pxa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c
index 3dc7c10..8d99573 100644
--- a/drivers/pwm/pwm-pxa.c
+++ b/drivers/pwm/pwm-pxa.c
@@ -8,7 +8,7 @@
* published by the Free Software Foundation.
*
* 2008-02-13 initial version
- * eric miao <eric.miao@marvell.com>
+ * eric miao <eric.miao@marvell.com>
*/
#include <linux/module.h>
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] pwm: core: use seq_puts() instead of seq_printf()
2013-12-19 4:31 [PATCH 1/3] pwm: core: use seq_puts() instead of seq_printf() Jingoo Han
2013-12-19 4:32 ` [PATCH 2/3] pwm: pwm-ep93xx: split module author names Jingoo Han
2013-12-19 4:34 ` [PATCH 3/3] pwm: pxa: remove unnecessary space before tabs Jingoo Han
@ 2013-12-20 9:58 ` Thierry Reding
2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2013-12-20 9:58 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-pwm
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
On Thu, Dec 19, 2013 at 01:31:24PM +0900, Jingoo Han wrote:
> For a constant format without additional arguments, use seq_puts()
> instead of seq_printf(). Also, the following checkpatch warning is
> fixed.
>
> WARNING: Prefer seq_puts to seq_printf
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pwm/core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
All three patches applied, thanks!
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-20 9:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-19 4:31 [PATCH 1/3] pwm: core: use seq_puts() instead of seq_printf() Jingoo Han
2013-12-19 4:32 ` [PATCH 2/3] pwm: pwm-ep93xx: split module author names Jingoo Han
2013-12-19 4:34 ` [PATCH 3/3] pwm: pxa: remove unnecessary space before tabs Jingoo Han
2013-12-20 9:58 ` [PATCH 1/3] pwm: core: use seq_puts() instead of seq_printf() Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).