linux-pwm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Chew Chiau Ee <chiau.ee.chew@intel.com>,
	linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chew Kean Ho <kean.ho.chew@intel.com>,
	Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>
Subject: Re: [PATCH] pwm: add support for Intel Low Power Subsystem PWM
Date: Wed, 22 Jan 2014 11:31:16 +0200	[thread overview]
Message-ID: <20140122093116.GR18029@intel.com> (raw)
In-Reply-To: <20140121194338.GA12085@ulmo.nvidia.com>

On Tue, Jan 21, 2014 at 08:43:39PM +0100, Thierry Reding wrote:
> The idea behind this is that only a single user can have access to a
> given PWM device at a time. The PWM device's PWMF_REQUESTED flag is set
> (and cleared) under the pwm_lock and any subsequent users will not be
> able to use that specific device (pwm_request() return -EBUSY).
> 
> There is obviously an assumption here that each user knows what they are
> doing and aren't calling any of the public pwm_*() functions
> concurrently. I haven't come across a situation where this is actually a
> problem because typically these functions are called either via sysfs or
> some other higher-level where synchronization is already properly
> handled.
> 
> So the only thing that drivers should be taking care of is synchronizing
> access to registers common to multiple PWM devices.

OK, and since LPSS PWM don't share registers we shouldn't need to do
anything here.

> Does that clarify things?

It does for me, thanks for the explanation.

  reply	other threads:[~2014-01-22  9:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20 18:00 [PATCH] pwm: add support for Intel Low Power Subsystem PWM Chew Chiau Ee
2014-01-20 13:28 ` One Thousand Gnomes
2014-01-21  8:52   ` Mika Westerberg
2014-01-21 19:43     ` Thierry Reding
2014-01-22  9:31       ` Mika Westerberg [this message]
2014-02-18 12:05         ` Chew, Chiau Ee
2014-01-23 16:21       ` One Thousand Gnomes
2014-02-26 14:38 ` Thierry Reding
2014-02-27  9:01   ` Mika Westerberg
2014-02-27  9:03     ` Chew, Chiau Ee
2014-02-27 13:13       ` Mika Westerberg
2014-02-27 13:34         ` Chew, Chiau Ee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140122093116.GR18029@intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=chiau.ee.chew@intel.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=kean.ho.chew@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=rebecca.swee.fun.chang@intel.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).