From: Thierry Reding <thierry.reding@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm,renesas-tpu: Add dependency on HAS_IOMEM
Date: Wed, 26 Feb 2014 15:12:44 +0100 [thread overview]
Message-ID: <20140226141243.GE29779@ulmo.nvidia.com> (raw)
In-Reply-To: <530DF4E7.1060900@nod.at>
[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]
On Wed, Feb 26, 2014 at 03:06:31PM +0100, Richard Weinberger wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 26.02.2014 13:08, schrieb Thierry Reding:
> > On Fri, Jan 31, 2014 at 01:45:18PM +0100, Richard Weinberger wrote:
> >> On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures.
> >>
> >> drivers/built-in.o: In function `tpu_probe': drivers/pwm/pwm-renesas-tpu.c:421: undefined reference to `devm_ioremap_resource'
> >>
> >> Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/pwm/Kconfig | 1 + 1 file changed, 1 insertion(+)
> >
> > In the long run I think it might be better to add a dummy implementation for devm_ioremap_resource() in order to make it build properly even for architectures where it isn't
> > implemented.
>
> And what should devm_ioremap_resource() or in general ioremap() do on archs without
> iomem?
> BUG()? Returning a random error and hoping that the driver handles it correctly? :)
>
> IMHO such a dummy implementation does not make much sense.
Well, it could still be useful for drivers that want to support
COMPILE_TEST. If we just make it return any error drivers should simply
refuse to probe just like if the error was genuine.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-02-26 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 12:45 [PATCH] pwm,renesas-tpu: Add dependency on HAS_IOMEM Richard Weinberger
2014-02-26 11:59 ` Richard Weinberger
2014-02-26 12:08 ` Thierry Reding
2014-02-26 14:06 ` Richard Weinberger
2014-02-26 14:12 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226141243.GE29779@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).