From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: MX28: leds/pwm: Using pwm driven led as heartbeat leads to kernel warning Date: Tue, 8 Apr 2014 10:41:50 +0200 Message-ID: <20140408084150.GC30127@piout.net> References: <53345C93.9040005@i2se.com> <533EB9AC.6040708@i2se.com> <20140404142656.GA16383@dragon> <20140404164446.GI4883@piout.net> <20140408073402.GC2438@dragon> <20140408075916.GA30127@piout.net> <20140408081848.GH2438@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from top.free-electrons.com ([176.31.233.9]:51613 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756037AbaDHIlx (ORCPT ); Tue, 8 Apr 2014 04:41:53 -0400 Content-Disposition: inline In-Reply-To: <20140408081848.GH2438@dragon> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Shawn Guo Cc: Stefan Wahren , Fabio Estevam , Thierry Reding , Bryan Wu , Richard Purdie , Sascha Hauer , linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-leds@vger.kernel.org On 08/04/2014 at 16:18:49 +0800, Shawn Guo wrote : > On Tue, Apr 08, 2014 at 09:59:16AM +0200, Alexandre Belloni wrote: > > The driver using the PWM should test the flag, have a look at: > > http://lxr.free-electrons.com/source/drivers/leds/leds-pwm.c#L183 > > Ah, right, that' how the flag works. Thanks, Alexandre. I send a patch > to set the flag for pwm-mxs driver shortly. > Actually, I had a closer look and I believe using clk_prepare_enable() in .config is wrong. Let me prepare a patch. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com