From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: "Alexandre Belloni" <alexandre.belloni@free-electrons.com>,
"Stefan Wahren" <stefan.wahren@i2se.com>,
linux-pwm@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-arm-kernel@lists.infradead.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] pwm: mxs: set pwm_chip can_sleep flag
Date: Wed, 9 Apr 2014 09:39:14 +0100 [thread overview]
Message-ID: <20140409083914.GN16119@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140409034115.GB2611@dragon>
On Wed, Apr 09, 2014 at 11:41:17AM +0800, Shawn Guo wrote:
> On Wed, Apr 09, 2014 at 12:44:18AM +0100, Russell King - ARM Linux wrote:
> > On Wed, Apr 09, 2014 at 01:16:54AM +0200, Alexandre Belloni wrote:
> > > I'm not home, else I'll try on my i.mx28 boards...
> >
> > I just tried heartbeat here, on iMX6, and it works fine. That's with this
> > in the DT:
>
> FYI. i.MX28 is known as 'mxs' sub-architecture and uses pwm-mxs driver
> rather than pwm-imx which is the one for i.MX6.
My point being by doing the above test is that the pwm_disable() call
in leds-pwm works correctly with iMX6 and the "troublesome" active-low
flag set at the leds-pwm level.
It wouldn't work on iMX6 if you tried to use the broken inversion on the
PWM output - it would have exactly the effects being reported on iMX28
as setting a duty of 100% would pull the signal low and disabling the PWM
will also pull the signal low (which are the two states heartbeat uses.)
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-04-09 8:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 11:29 [PATCH] pwm: mxs: set pwm_chip can_sleep flag Shawn Guo
2014-04-08 13:46 ` Stefan Wahren
2014-04-08 14:18 ` Alexandre Belloni
2014-04-08 16:53 ` Stefan Wahren
2014-04-08 23:16 ` Alexandre Belloni
2014-04-08 23:44 ` Russell King - ARM Linux
2014-04-09 3:41 ` Shawn Guo
2014-04-09 8:39 ` Russell King - ARM Linux [this message]
2014-04-08 17:59 ` Uwe Kleine-König
2014-04-08 23:42 ` Alexandre Belloni
2014-04-09 8:23 ` Uwe Kleine-König
2014-04-09 10:03 ` Alexandre Belloni
2014-04-09 10:46 ` Thierry Reding
2014-04-09 14:35 ` Uwe Kleine-König
2014-04-25 14:11 ` Stefan Wahren
2014-04-08 14:24 ` Alexandre Belloni
2014-04-08 17:26 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409083914.GN16119@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=shawn.guo@freescale.com \
--cc=stefan.wahren@i2se.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).