From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Chew, Chiau Ee" <chiau.ee.chew@intel.com>
Cc: "Li, Aubrey" <aubrey.li@linux.intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
Alan Cox <alan@linux.intel.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pwm_lpss: Add support for PCI devices
Date: Mon, 14 Apr 2014 11:59:11 +0300 [thread overview]
Message-ID: <20140414085911.GL19349@intel.com> (raw)
In-Reply-To: <604BF5F4C5D71041942BC7E84ED659EA01570A7A@PGSMSX103.gar.corp.intel.com>
On Mon, Apr 14, 2014 at 02:05:25AM +0000, Chew, Chiau Ee wrote:
> > > MODULE_DESCRIPTION("PWM driver for Intel LPSS");
> > >MODULE_AUTHOR("Mika
> > > Westerberg <mika.westerberg@linux.intel.com>");
> > > MODULE_LICENSE("GPL v2");
> > > MODULE_ALIAS("platform:pwm-lpss");
> >
> > Looks a good idea to combine pci and acpi driver together.
> > Since pci driver is added, here the alias need to be refined.
> > Others look good.
> >
> > Thanks,
> > -Aubrey
>
> Ok. I will change it to MODULE_ALIAS("pci/platform:pwm-lpss");
Hmm, does that really work like that?
For PCI and ACPI you already have tables with MODULE_DEVICE_TABLE().
For pure platform driver (which is probably not going to be used) you nede
to have MODULE_ALIAS() if you want modprobe to load it automagically.
next prev parent reply other threads:[~2014-04-14 8:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 13:58 [PATCH] pwm_lpss: Add support for PCI devices Chew Chiau Ee
2014-04-13 10:32 ` Li, Aubrey
2014-04-14 2:05 ` Chew, Chiau Ee
2014-04-14 8:59 ` Mika Westerberg [this message]
2014-04-15 8:59 ` Chew, Chiau Ee
2014-04-14 8:18 ` Mika Westerberg
2014-04-15 8:41 ` Chew, Chiau Ee
2014-04-15 9:03 ` Mika Westerberg
2014-04-15 9:06 ` Chew, Chiau Ee
2014-05-12 23:18 ` Darren Hart
2014-05-13 6:59 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414085911.GL19349@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=alan@linux.intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=chiau.ee.chew@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).