From: Thierry Reding <thierry.reding@gmail.com>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: linux-pwm@vger.kernel.org, broonie@kernel.org,
swarren@nvidia.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] pwm: ftm-pwm: Convert to direct regmap API usage.
Date: Mon, 28 Apr 2014 16:59:31 +0200 [thread overview]
Message-ID: <20140428145930.GC28443@ulmo> (raw)
In-Reply-To: <1395377590-23537-3-git-send-email-Li.Xiubo@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
On Fri, Mar 21, 2014 at 12:53:09PM +0800, Xiubo Li wrote:
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
> drivers/pwm/pwm-fsl-ftm.c | 83 +++++++++++++++++++++++++----------------------
> 1 file changed, 44 insertions(+), 39 deletions(-)
This could explain the advantages of converting to regmap. Looking at
this diffstat above, it's not immediately obvious that there's an
advantage because you end up adding 5 lines.
Again I'm guessing this is in preparation to add endianess support, and
it will be really easy to add that using regmap, so the gains will only
become obvious later on.
That's the kind of thing I'd like to see in the patch description. It
tells me why this patch makes sense.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-28 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 4:53 [PATCH 0/3] FTM PWM adds regmap and endianness support Xiubo Li
2014-03-21 4:53 ` [PATCH 1/3] pwm: ftm-pwm: Clean up the code Xiubo Li
2014-04-28 14:57 ` Thierry Reding
2014-04-28 15:16 ` Li.Xiubo
2014-03-21 4:53 ` [PATCH 2/3] pwm: ftm-pwm: Convert to direct regmap API usage Xiubo Li
2014-04-28 14:59 ` Thierry Reding [this message]
2014-04-28 15:14 ` Li.Xiubo
2014-03-21 4:53 ` [PATCH 3/3] pwm: ftm-pwm: Add big-endian support Xiubo Li
2014-04-28 15:02 ` Thierry Reding
2014-04-28 15:11 ` Li.Xiubo
2014-04-10 6:05 ` [PATCH 0/3] FTM PWM adds regmap and endianness support Li.Xiubo
2014-04-28 13:10 ` Thierry Reding
2014-04-28 14:26 ` Li.Xiubo
2014-04-28 14:56 ` Thierry Reding
2014-04-28 15:21 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428145930.GC28443@ulmo \
--to=thierry.reding@gmail.com \
--cc=Li.Xiubo@freescale.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).