From: Thierry Reding <thierry.reding@gmail.com>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: linux-pwm@vger.kernel.org, broonie@kernel.org,
swarren@nvidia.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] pwm: ftm-pwm: Add big-endian support
Date: Mon, 28 Apr 2014 17:02:08 +0200 [thread overview]
Message-ID: <20140428150207.GD28443@ulmo> (raw)
In-Reply-To: <1395377590-23537-4-git-send-email-Li.Xiubo@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Fri, Mar 21, 2014 at 12:53:10PM +0800, Xiubo Li wrote:
> Now for the following scenarios:
>
> SoC | CPU | FTM-PWM | 'big-endian' property is needed?
> -------------|--------|---------|---------------------------------
> Vybird | LE | LE | No
> LS1 | LE | BE | Yes
> LS2 | LE | LE | No
>
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
> drivers/pwm/pwm-fsl-ftm.c | 6 ++++++
> 1 file changed, 6 insertions(+)
And this should probably describe in text what happens. The table may
look good, but you don't give a real description of what the change
does.
Oh, and doesn't this change need to update the device tree binding since
you now have an additional property?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-28 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 4:53 [PATCH 0/3] FTM PWM adds regmap and endianness support Xiubo Li
2014-03-21 4:53 ` [PATCH 1/3] pwm: ftm-pwm: Clean up the code Xiubo Li
2014-04-28 14:57 ` Thierry Reding
2014-04-28 15:16 ` Li.Xiubo
2014-03-21 4:53 ` [PATCH 2/3] pwm: ftm-pwm: Convert to direct regmap API usage Xiubo Li
2014-04-28 14:59 ` Thierry Reding
2014-04-28 15:14 ` Li.Xiubo
2014-03-21 4:53 ` [PATCH 3/3] pwm: ftm-pwm: Add big-endian support Xiubo Li
2014-04-28 15:02 ` Thierry Reding [this message]
2014-04-28 15:11 ` Li.Xiubo
2014-04-10 6:05 ` [PATCH 0/3] FTM PWM adds regmap and endianness support Li.Xiubo
2014-04-28 13:10 ` Thierry Reding
2014-04-28 14:26 ` Li.Xiubo
2014-04-28 14:56 ` Thierry Reding
2014-04-28 15:21 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428150207.GD28443@ulmo \
--to=thierry.reding@gmail.com \
--cc=Li.Xiubo@freescale.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).