From: Thierry Reding <thierry.reding@gmail.com>
To: Ajay Kumar <ajaykumar.rs@samsung.com>
Cc: linux-pwm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
ajaynumb@gmail.com, tomasz.figa@gmail.com, abrestic@chromium.org,
jg1.han@samsung.com, sachin.kamat@linaro.org, joshi@samsung.com,
prashanth.g@samsung.com
Subject: Re: [PATCH] pwm: samsung: do not set manual update bit in pwm_samsung_config
Date: Wed, 21 May 2014 12:20:43 +0200 [thread overview]
Message-ID: <20140521102042.GB22783@ulmo> (raw)
In-Reply-To: <1399906581-29298-1-git-send-email-ajaykumar.rs@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On Mon, May 12, 2014 at 08:26:21PM +0530, Ajay Kumar wrote:
> pwm_samsung_config sets manual update bit via call to
> pwm_samsung_enable even when the channel is already running.
> This causes noticable flickers on display if we try to change
> the backlight value from 0 to MAX, continiously.
>
> So, we remove the call to pwm_samsung_enable from
> pwm_samsung_config to avoid the flicker and this change doesn't
> harm normal working since the pwm_bl core already takes care of
> calling pwm_samsung_enable whenever needed.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> ---
> drivers/pwm/pwm-samsung.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-05-21 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 14:56 [PATCH] pwm: samsung: do not set manual update bit in pwm_samsung_config Ajay Kumar
2014-05-12 14:59 ` Ajay kumar
2014-05-12 17:11 ` Tomasz Figa
2014-05-21 10:20 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521102042.GB22783@ulmo \
--to=thierry.reding@gmail.com \
--cc=abrestic@chromium.org \
--cc=ajaykumar.rs@samsung.com \
--cc=ajaynumb@gmail.com \
--cc=jg1.han@samsung.com \
--cc=joshi@samsung.com \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=prashanth.g@samsung.com \
--cc=sachin.kamat@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).