* [PATCH] pwm: atmel: set pwm_chip can_sleep flag
@ 2014-04-09 18:26 Alexandre Belloni
2014-04-10 13:51 ` Nicolas Ferre
2014-05-21 10:26 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Alexandre Belloni @ 2014-04-09 18:26 UTC (permalink / raw)
To: Thierry Reding
Cc: linux-pwm, linux-kernel, linux-arm-kernel, Alexandre Belloni
atmel_pwm_config() calls clk_get_rate() which might sleep, so we need to set
pwm_chip can_sleep flag.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
drivers/pwm/pwm-atmel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c
index 0e589594b1cb..180e34e46617 100644
--- a/drivers/pwm/pwm-atmel.c
+++ b/drivers/pwm/pwm-atmel.c
@@ -369,6 +369,7 @@ static int atmel_pwm_probe(struct platform_device *pdev)
atmel_pwm->chip.base = -1;
atmel_pwm->chip.npwm = 4;
+ atmel_pwm->chip.can_sleep = true;
atmel_pwm->config = data->config;
ret = pwmchip_add(&atmel_pwm->chip);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: atmel: set pwm_chip can_sleep flag
2014-04-09 18:26 [PATCH] pwm: atmel: set pwm_chip can_sleep flag Alexandre Belloni
@ 2014-04-10 13:51 ` Nicolas Ferre
2014-05-21 10:26 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2014-04-10 13:51 UTC (permalink / raw)
To: Alexandre Belloni, Thierry Reding
Cc: linux-pwm, linux-kernel, linux-arm-kernel
On 09/04/2014 20:26, Alexandre Belloni :
> atmel_pwm_config() calls clk_get_rate() which might sleep, so we need to set
> pwm_chip can_sleep flag.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/pwm/pwm-atmel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c
> index 0e589594b1cb..180e34e46617 100644
> --- a/drivers/pwm/pwm-atmel.c
> +++ b/drivers/pwm/pwm-atmel.c
> @@ -369,6 +369,7 @@ static int atmel_pwm_probe(struct platform_device *pdev)
>
> atmel_pwm->chip.base = -1;
> atmel_pwm->chip.npwm = 4;
> + atmel_pwm->chip.can_sleep = true;
> atmel_pwm->config = data->config;
>
> ret = pwmchip_add(&atmel_pwm->chip);
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: atmel: set pwm_chip can_sleep flag
2014-04-09 18:26 [PATCH] pwm: atmel: set pwm_chip can_sleep flag Alexandre Belloni
2014-04-10 13:51 ` Nicolas Ferre
@ 2014-05-21 10:26 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2014-05-21 10:26 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: linux-pwm, linux-kernel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
On Wed, Apr 09, 2014 at 08:26:09PM +0200, Alexandre Belloni wrote:
> atmel_pwm_config() calls clk_get_rate() which might sleep, so we need to set
> pwm_chip can_sleep flag.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/pwm/pwm-atmel.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-21 10:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-09 18:26 [PATCH] pwm: atmel: set pwm_chip can_sleep flag Alexandre Belloni
2014-04-10 13:51 ` Nicolas Ferre
2014-05-21 10:26 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).