From: Thierry Reding <thierry.reding@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre BOURDIOL <alexandre.bourdiol@st.com>,
Philippe Begnic <philippe.begnic@st.com>,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH RESEND] PWM: ab8500: Fix wrong value shift for disable/enable PWM
Date: Wed, 21 May 2014 12:30:27 +0200 [thread overview]
Message-ID: <20140521103026.GE22783@ulmo> (raw)
In-Reply-To: <1397049594.5246.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
On Wed, Apr 09, 2014 at 09:19:54PM +0800, Axel Lin wrote:
> Current code only works when pdev->id is 1. Fix it by passing correct bitvalues
> argument to abx500_mask_and_set_register_interruptible.
>
> Having DISABLE_PWM/ENABLE_PWM does not make the code better in readability
> because the bitvalues depends on pdev->id.
> Thus drop defines for DISABLE_PWM/ENABLE_PWM.
>
> This patch also removes a unnecessary return in ab8500_pwm_disable.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Alexandre BOURDIOL <alexandre.bourdiol@st.com>
> Acked-by: Philippe Begnic <philippe.begnic@st.com>
> ---
> drivers/pwm/pwm-ab8500.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-05-21 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 13:19 [PATCH RESEND] PWM: ab8500: Fix wrong value shift for disable/enable PWM Axel Lin
2014-05-21 10:30 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521103026.GE22783@ulmo \
--to=thierry.reding@gmail.com \
--cc=alexandre.bourdiol@st.com \
--cc=axel.lin@ingics.com \
--cc=linus.walleij@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=philippe.begnic@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).